Patch "net: dsa: felix: fix internal MDIO controller resource length" has been added to the 6.1-stable tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This is a note to let you know that I've just added the patch titled

    net: dsa: felix: fix internal MDIO controller resource length

to the 6.1-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     net-dsa-felix-fix-internal-mdio-controller-resource-.patch
and it can be found in the queue-6.1 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.



commit e98ffc2645117a6a2b339db3888a40b7a26582df
Author: Vladimir Oltean <vladimir.oltean@xxxxxxx>
Date:   Fri Feb 24 17:52:34 2023 +0200

    net: dsa: felix: fix internal MDIO controller resource length
    
    [ Upstream commit 940af261321307cd1dd0fe8f9c34a6129f9d4bdc ]
    
    The blamed commit did not properly convert the resource start/end format
    into the DEFINE_RES_MEM_NAMED() start/length format, resulting in a
    resource for vsc9959_imdio_res which is much longer than expected:
    
    $ cat /proc/iomem
    1f8000000-1f815ffff : pcie@1f0000000
      1f8140000-1f815ffff : 0000:00:00.5
        1f8148030-1f815006f : imdio
    
    vs (correct)
    
    $ cat /proc/iomem
    1f8000000-1f815ffff : pcie@1f0000000
      1f8140000-1f815ffff : 0000:00:00.5
        1f8148030-1f814803f : imdio
    
    Luckily it's not big enough to exceed the size of the parent resource
    (pci_resource_end(pdev, VSC9959_IMDIO_PCI_BAR)), and it doesn't overlap
    with anything else that the Linux driver uses currently, so the larger
    than expected size isn't a practical problem that I can see. Although it
    is clearly wrong in the /proc/iomem output.
    
    Fixes: 044d447a801f ("net: dsa: felix: use DEFINE_RES_MEM_NAMED for resources")
    Signed-off-by: Vladimir Oltean <vladimir.oltean@xxxxxxx>
    Reviewed-by: Florian Fainelli <f.fainelli@xxxxxxxxx>
    Signed-off-by: David S. Miller <davem@xxxxxxxxxxxxx>
    Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>

diff --git a/drivers/net/dsa/ocelot/felix_vsc9959.c b/drivers/net/dsa/ocelot/felix_vsc9959.c
index 26a35ae322d10..cc89cff029e1f 100644
--- a/drivers/net/dsa/ocelot/felix_vsc9959.c
+++ b/drivers/net/dsa/ocelot/felix_vsc9959.c
@@ -513,7 +513,7 @@ static const char * const vsc9959_resource_names[TARGET_MAX] = {
  * SGMII/QSGMII MAC PCS can be found.
  */
 static const struct resource vsc9959_imdio_res =
-	DEFINE_RES_MEM_NAMED(0x8030, 0x8040, "imdio");
+	DEFINE_RES_MEM_NAMED(0x8030, 0x10, "imdio");
 
 static const struct reg_field vsc9959_regfields[REGFIELD_MAX] = {
 	[ANA_ADVLEARN_VLAN_CHK] = REG_FIELD(ANA_ADVLEARN, 6, 6),



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux