Re: Patch "dm flakey: fix a bug with 32-bit highmem systems" has been added to the 5.10-stable tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Mar 07, 2023 at 01:21:45PM +0100, gregkh@xxxxxxxxxxxxxxxxxxx wrote:
> 
> This is a note to let you know that I've just added the patch titled
> 
>     dm flakey: fix a bug with 32-bit highmem systems
> 
> to the 5.10-stable tree which can be found at:
>     http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
> 
> The filename of the patch is:
>      dm-flakey-fix-a-bug-with-32-bit-highmem-systems.patch
> and it can be found in the queue-5.10 subdirectory.
> 
> If you, or anyone else, feels it should not be added to the stable tree,
> please let <stable@xxxxxxxxxxxxxxx> know about it.
> 
> 
> >From 8eb29c4fbf9661e6bd4dd86197a37ffe0ecc9d50 Mon Sep 17 00:00:00 2001
> From: Mikulas Patocka <mpatocka@xxxxxxxxxx>
> Date: Sun, 22 Jan 2023 14:03:31 -0500
> Subject: dm flakey: fix a bug with 32-bit highmem systems
> 
> From: Mikulas Patocka <mpatocka@xxxxxxxxxx>
> 
> commit 8eb29c4fbf9661e6bd4dd86197a37ffe0ecc9d50 upstream.
> 
> The function page_address does not work with 32-bit systems with high
> memory. Use bvec_kmap_local/kunmap_local instead.
> 
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Mikulas Patocka <mpatocka@xxxxxxxxxx>
> Reviewed-by: Sweet Tea Dorminy <sweettea-kernel@xxxxxxxxxx>
> Signed-off-by: Mike Snitzer <snitzer@xxxxxxxxxx>
> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> ---
>  drivers/md/dm-flakey.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> --- a/drivers/md/dm-flakey.c
> +++ b/drivers/md/dm-flakey.c
> @@ -305,8 +305,9 @@ static void corrupt_bio_data(struct bio
>  			struct page *page = bio_iter_page(bio, iter);
>  			if (unlikely(page == ZERO_PAGE(0)))
>  				break;
> -			segment = (page_address(page) + bio_iter_offset(bio, iter));
> +			segment = bvec_kmap_local(&bvec);
>  			segment[corrupt_bio_byte] = fc->corrupt_bio_value;
> +			kunmap_local(segment);
>  			DMDEBUG("Corrupting data bio=%p by writing %u to byte %u "
>  				"(rw=%c bi_opf=%u bi_sector=%llu size=%u)\n",
>  				bio, fc->corrupt_bio_value, fc->corrupt_bio_byte,
> 
> 
> Patches currently in stable-queue which might be from mpatocka@xxxxxxxxxx are
> 
> queue-5.10/dm-flakey-don-t-corrupt-the-zero-page.patch
> queue-5.10/dm-flakey-fix-logic-when-corrupting-a-bio.patch
> queue-5.10/dm-flakey-fix-a-bug-with-32-bit-highmem-systems.patch

Oops, no, this one breaks the build on 5.10 and older systems, I've
dropped it.

thanks,

greg k-h



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux