Patch "irqdomain: Drop bogus fwspec-mapping error handling" has been added to the 6.2-stable tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This is a note to let you know that I've just added the patch titled

    irqdomain: Drop bogus fwspec-mapping error handling

to the 6.2-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     irqdomain-drop-bogus-fwspec-mapping-error-handling.patch
and it can be found in the queue-6.2 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.


>From e3b7ab025e931accdc2c12acf9b75c6197f1c062 Mon Sep 17 00:00:00 2001
From: Johan Hovold <johan+linaro@xxxxxxxxxx>
Date: Mon, 13 Feb 2023 11:42:45 +0100
Subject: irqdomain: Drop bogus fwspec-mapping error handling

From: Johan Hovold <johan+linaro@xxxxxxxxxx>

commit e3b7ab025e931accdc2c12acf9b75c6197f1c062 upstream.

In case a newly allocated IRQ ever ends up not having any associated
struct irq_data it would not even be possible to dispose the mapping.

Replace the bogus disposal with a WARN_ON().

This will also be used to fix a shared-interrupt mapping race, hence the
CC-stable tag.

Fixes: 1e2a7d78499e ("irqdomain: Don't set type when mapping an IRQ")
Cc: stable@xxxxxxxxxxxxxxx      # 4.8
Tested-by: Hsin-Yi Wang <hsinyi@xxxxxxxxxxxx>
Tested-by: Mark-PK Tsai <mark-pk.tsai@xxxxxxxxxxxx>
Signed-off-by: Johan Hovold <johan+linaro@xxxxxxxxxx>
Signed-off-by: Marc Zyngier <maz@xxxxxxxxxx>
Link: https://lore.kernel.org/r/20230213104302.17307-4-johan+linaro@xxxxxxxxxx
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
---
 kernel/irq/irqdomain.c |    7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

--- a/kernel/irq/irqdomain.c
+++ b/kernel/irq/irqdomain.c
@@ -853,13 +853,8 @@ unsigned int irq_create_fwspec_mapping(s
 	}
 
 	irq_data = irq_get_irq_data(virq);
-	if (!irq_data) {
-		if (irq_domain_is_hierarchy(domain))
-			irq_domain_free_irqs(virq, 1);
-		else
-			irq_dispose_mapping(virq);
+	if (WARN_ON(!irq_data))
 		return 0;
-	}
 
 	/* Store trigger type */
 	irqd_set_trigger_type(irq_data, type);


Patches currently in stable-queue which might be from johan+linaro@xxxxxxxxxx are

queue-6.2/rtc-pm8xxx-fix-set-alarm-race.patch
queue-6.2/irqdomain-fix-association-race.patch
queue-6.2/pci-qcom-fix-host-init-error-handling.patch
queue-6.2/irqdomain-fix-domain-registration-race.patch
queue-6.2/irqdomain-drop-bogus-fwspec-mapping-error-handling.patch
queue-6.2/irqdomain-fix-mapping-creation-race.patch
queue-6.2/drm-panel-edp-fix-name-for-ivo-product-id-854b.patch
queue-6.2/irqdomain-refactor-__irq_domain_alloc_irqs.patch
queue-6.2/irqdomain-fix-disassociation-race.patch
queue-6.2/irqdomain-look-for-existing-mapping-only-once.patch
queue-6.2/arm64-dts-qcom-sc8280xp-correct-spmi-bus-address-cel.patch



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux