This is a note to let you know that I've just added the patch titled nbd: fix possible overflow for 'first_minor' in nbd_dev_add() to the 5.10-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: nbd-fix-possible-overflow-for-first_minor-in-nbd_dev_add.patch and it can be found in the queue-5.10 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let <stable@xxxxxxxxxxxxxxx> know about it. >From 940c264984fd1457918393c49674f6b39ee16506 Mon Sep 17 00:00:00 2001 From: Yu Kuai <yukuai3@xxxxxxxxxx> Date: Tue, 2 Nov 2021 09:52:35 +0800 Subject: nbd: fix possible overflow for 'first_minor' in nbd_dev_add() From: Yu Kuai <yukuai3@xxxxxxxxxx> commit 940c264984fd1457918393c49674f6b39ee16506 upstream. If 'part_shift' is not zero, then 'index << part_shift' might overflow to a value that is not greater than '0xfffff', then sysfs might complains about duplicate creation. Fixes: b0d9111a2d53 ("nbd: use an idr to keep track of nbd devices") Signed-off-by: Yu Kuai <yukuai3@xxxxxxxxxx> Reviewed-by: Josef Bacik <josef@xxxxxxxxxxxxxx> Link: https://lore.kernel.org/r/20211102015237.2309763-3-yebin10@xxxxxxxxxx Signed-off-by: Jens Axboe <axboe@xxxxxxxxx> Signed-off-by: Wen Yang <wenyang.linux@xxxxxxxxxxx> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> --- drivers/block/nbd.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) --- a/drivers/block/nbd.c +++ b/drivers/block/nbd.c @@ -1773,11 +1773,11 @@ static int nbd_dev_add(int index) disk->major = NBD_MAJOR; /* Too big first_minor can cause duplicate creation of - * sysfs files/links, since MKDEV() expect that the max bits of - * first_minor is 20. + * sysfs files/links, since index << part_shift might overflow, or + * MKDEV() expect that the max bits of first_minor is 20. */ disk->first_minor = index << part_shift; - if (disk->first_minor > MINORMASK) { + if (disk->first_minor < index || disk->first_minor > MINORMASK) { err = -EINVAL; goto out_free_idr; } Patches currently in stable-queue which might be from yukuai3@xxxxxxxxxx are queue-5.10/nbd-fix-possible-overflow-on-first_minor-in-nbd_dev_add.patch queue-5.10/nbd-fix-possible-overflow-for-first_minor-in-nbd_dev_add.patch queue-5.10/nbd-fix-max-value-for-first_minor.patch