This is a note to let you know that I've just added the patch titled revert "squashfs: harden sanity check in squashfs_read_xattr_id_table" to the 4.14-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: revert-squashfs-harden-sanity-check-in-squashfs_read_xattr_id_table.patch and it can be found in the queue-4.14 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let <stable@xxxxxxxxxxxxxxx> know about it. >From a5b21d8d791cd4db609d0bbcaa9e0c7e019888d1 Mon Sep 17 00:00:00 2001 From: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> Date: Thu, 2 Feb 2023 18:07:35 -0800 Subject: revert "squashfs: harden sanity check in squashfs_read_xattr_id_table" From: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> commit a5b21d8d791cd4db609d0bbcaa9e0c7e019888d1 upstream. This fix was nacked by Philip, for reasons identified in the email linked below. Link: https://lkml.kernel.org/r/68f15d67-8945-2728-1f17-5b53a80ec52d@xxxxxxxxxxxxxxx Fixes: 72e544b1b28325 ("squashfs: harden sanity check in squashfs_read_xattr_id_table") Cc: Alexey Khoroshilov <khoroshilov@xxxxxxxxx> Cc: Fedor Pchelkin <pchelkin@xxxxxxxxx> Cc: Phillip Lougher <phillip@xxxxxxxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> --- fs/squashfs/xattr_id.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/fs/squashfs/xattr_id.c +++ b/fs/squashfs/xattr_id.c @@ -89,7 +89,7 @@ __le64 *squashfs_read_xattr_id_table(str /* Sanity check values */ /* there is always at least one xattr id */ - if (*xattr_ids <= 0) + if (*xattr_ids == 0) return ERR_PTR(-EINVAL); len = SQUASHFS_XATTR_BLOCK_BYTES(*xattr_ids); Patches currently in stable-queue which might be from akpm@xxxxxxxxxxxxxxxxxxxx are queue-4.14/migrate-hugetlb-check-for-hugetlb-shared-pmd-in-node-migration.patch queue-4.14/squashfs-harden-sanity-check-in-squashfs_read_xattr_.patch queue-4.14/hugetlb-check-for-undefined-shift-on-32-bit-architectures.patch queue-4.14/aio-fix-mremap-after-fork-null-deref.patch queue-4.14/mm-swapfile-add-cond_resched-in-get_swap_pages.patch queue-4.14/revert-squashfs-harden-sanity-check-in-squashfs_read_xattr_id_table.patch queue-4.14/mm-hugetlb-proc-check-for-hugetlb-shared-pmd-in-proc-pid-smaps.patch queue-4.14/squashfs-fix-handling-and-sanity-checking-of-xattr_ids-count.patch