On Wed, Feb 15, 2023 at 05:49:41PM +0100, Matthieu Baerts wrote:
Hi Sasha, On 15/02/2023 17:34, Sasha Levin wrote:This is a note to let you know that I've just added the patch titled mptcp: deduplicate error paths on endpoint creation to the 6.1-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: mptcp-deduplicate-error-paths-on-endpoint-creation.patch and it can be found in the queue-6.1 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let <stable@xxxxxxxxxxxxxxx> know about it.Thank you for backporting this patch. Because it slightly changes the behaviour by returning different err codes to some netlink commands, it might be safer not to backport this patch. Instead, I suggest to take the version of "mptcp: fix locking for in-kernel listener creation" I sent yesterday: https://lore.kernel.org/stable/20230214-upstream-stable-20230214-linux-6-1-12-rc1-mptcp-fixes-v1-0-02f36fa30f8c@xxxxxxxxxxxx/T/ It looks like it is the same as the patch you sent a few minutes ago for the v5.15 tree. WDYT?
In general we'd rather stay aligned with upstream. If we know that this change is introducing a bug, we should fix it upstream too, and if it doesn't - there shouldn't be a problem, right? :) -- Thanks, Sasha
