Patch "net: dsa: microchip: fix probe of I2C-connected KSZ8563" has been added to the 6.1-stable tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This is a note to let you know that I've just added the patch titled

    net: dsa: microchip: fix probe of I2C-connected KSZ8563

to the 6.1-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     net-dsa-microchip-fix-probe-of-i2c-connected-ksz8563.patch
and it can be found in the queue-6.1 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.



commit f1317d72351fce6867820ddb014d137ac807c9a5
Author: Ahmad Fatoum <a.fatoum@xxxxxxxxxxxxxx>
Date:   Fri Jan 20 12:09:32 2023 +0100

    net: dsa: microchip: fix probe of I2C-connected KSZ8563
    
    [ Upstream commit 360fdc999d92db4a4adbba0db8641396dc9f1b13 ]
    
    Starting with commit eee16b147121 ("net: dsa: microchip: perform the
    compatibility check for dev probed"), the KSZ switch driver now bails
    out if it thinks the DT compatible doesn't match the actual chip ID
    read back from the hardware:
    
      ksz9477-switch 1-005f: Device tree specifies chip KSZ9893 but found
      KSZ8563, please fix it!
    
    For the KSZ8563, which used ksz_switch_chips[KSZ9893], this was fine
    at first, because it indeed shares the same chip id as the KSZ9893.
    
    Commit b44908095612 ("net: dsa: microchip: add separate struct
    ksz_chip_data for KSZ8563 chip") started differentiating KSZ9893
    compatible chips by consulting the 0x1F register. The resulting breakage
    was fixed for the SPI driver in the same commit by introducing the
    appropriate ksz_switch_chips[KSZ8563], but not for the I2C driver.
    
    Fix this for I2C-connected KSZ8563 now to get it probing again.
    
    Fixes: b44908095612 ("net: dsa: microchip: add separate struct ksz_chip_data for KSZ8563 chip").
    Reviewed-by: Andrew Lunn <andrew@xxxxxxx>
    Signed-off-by: Ahmad Fatoum <a.fatoum@xxxxxxxxxxxxxx>
    Acked-by: Arun Ramadoss <arun.ramadoss@xxxxxxxxxxxxx>
    Reviewed-by: Florian Fainelli <f.fainelli@xxxxxxxxx>
    Link: https://lore.kernel.org/r/20230120110933.1151054-1-a.fatoum@xxxxxxxxxxxxxx
    Signed-off-by: Jakub Kicinski <kuba@xxxxxxxxxx>
    Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>

diff --git a/drivers/net/dsa/microchip/ksz9477_i2c.c b/drivers/net/dsa/microchip/ksz9477_i2c.c
index 3763930dc6fc..aae1dadef882 100644
--- a/drivers/net/dsa/microchip/ksz9477_i2c.c
+++ b/drivers/net/dsa/microchip/ksz9477_i2c.c
@@ -105,7 +105,7 @@ static const struct of_device_id ksz9477_dt_ids[] = {
 	},
 	{
 		.compatible = "microchip,ksz8563",
-		.data = &ksz_switch_chips[KSZ9893]
+		.data = &ksz_switch_chips[KSZ8563]
 	},
 	{
 		.compatible = "microchip,ksz9567",



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux