This is a note to let you know that I've just added the patch titled Revert "ext4: fix delayed allocation bug in ext4_clu_mapped for bigalloc + inline" to the 4.19-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: revert-ext4-fix-delayed-allocation-bug-in-ext4_clu_mapped-for-bigalloc-inline.patch and it can be found in the queue-4.19 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let <stable@xxxxxxxxxxxxxxx> know about it. >From 0fc4d61400fcc65f5d079d9a26e65ed44597f849 Mon Sep 17 00:00:00 2001 From: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> Date: Sun, 22 Jan 2023 15:10:23 +0100 Subject: Revert "ext4: fix delayed allocation bug in ext4_clu_mapped for bigalloc + inline" From: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> This reverts commit 1ed1eef0551bebee8e56973ccd0900e3578edfb7 which is commit 131294c35ed6f777bd4e79d42af13b5c41bf2775 upstream. Eric writes: I recommend not backporting this patch or the other three patches apparently intended to support it to 4.19 stable. All these patches are related to ext4's bigalloc feature, which was experimental as of 4.19 (expressly noted by contemporary versions of e2fsprogs) and also suffered from a number of bugs. A significant number of additional patches that were applied to 5.X kernels over time would have to be backported to 4.19 for the patch below to function correctly. It's really not worth doing that given bigalloc's experimental status as of 4.19 and the very rare combination of the bigalloc and inline features. Link: https://lore.kernel.org/r/Y8mAe1SlcLD5fykg@debian-BULLSEYE-live-builder-AMD64 Cc: Eric Whitney <enwlinux@xxxxxxxxx> Cc: Theodore Ts'o <tytso@xxxxxxx> Cc: Sasha Levin <sashal@xxxxxxxxxx> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> --- fs/ext4/extents.c | 8 -------- 1 file changed, 8 deletions(-) --- a/fs/ext4/extents.c +++ b/fs/ext4/extents.c @@ -5984,14 +5984,6 @@ int ext4_clu_mapped(struct inode *inode, struct ext4_extent *extent; ext4_lblk_t first_lblk, first_lclu, last_lclu; - /* - * if data can be stored inline, the logical cluster isn't - * mapped - no physical clusters have been allocated, and the - * file has no extents - */ - if (ext4_test_inode_state(inode, EXT4_STATE_MAY_INLINE_DATA)) - return 0; - /* search for the extent closest to the first block in the cluster */ path = ext4_find_extent(inode, EXT4_C2B(sbi, lclu), NULL, 0); if (IS_ERR(path)) { Patches currently in stable-queue which might be from gregkh@xxxxxxxxxxxxxxxxxxx are queue-4.19/usb-serial-option-add-quectel-em05cn-modem.patch queue-4.19/add-exception-protection-processing-for-vd-in-axi_chan_handle_err-function.patch queue-4.19/x86-fpu-use-_alignof-to-avoid-undefined-behavior-in-type_align.patch queue-4.19/usb-serial-option-add-quectel-em05-g-rs-modem.patch queue-4.19/usb-serial-option-add-quectel-em05-g-cs-modem.patch queue-4.19/mmc-sunxi-mmc-fix-clock-refcount-imbalance-during-unbind.patch queue-4.19/serial-pch_uart-pass-correct-sg-to-dma_unmap_sg.patch queue-4.19/xhci-fix-null-pointer-dereference-when-host-dies.patch queue-4.19/usb-serial-cp210x-add-scalance-lpe-9000-device-id.patch queue-4.19/nilfs2-fix-general-protection-fault-in-nilfs_btree_insert.patch queue-4.19/usb-host-ehci-fsl-fix-module-alias.patch queue-4.19/revert-ext4-fix-reserved-cluster-accounting-at-delayed-write-time.patch queue-4.19/revert-ext4-add-new-pending-reservation-mechanism.patch queue-4.19/xhci-pci-set-the-dma-max_seg_size.patch queue-4.19/usb-typec-altmodes-displayport-fix-pin-assignment-calculation.patch queue-4.19/usb-serial-option-add-quectel-ec200u-modem.patch queue-4.19/usb-xhci-check-endpoint-is-valid-before-dereferencing-it.patch queue-4.19/usb-misc-iowarrior-fix-up-header-size-for-usb_device_id_codemercs_iow100.patch queue-4.19/usb-serial-option-add-quectel-em05-g-gr-modem.patch queue-4.19/usb-typec-altmodes-displayport-add-pin-assignment-helper.patch queue-4.19/comedi-adv_pci1760-fix-pwm-instruction-handling.patch queue-4.19/revert-ext4-fix-delayed-allocation-bug-in-ext4_clu_mapped-for-bigalloc-inline.patch queue-4.19/usb-core-hub-disable-autosuspend-for-ti-tusb8041.patch queue-4.19/usb-gadget-f_ncm-fix-potential-null-ptr-deref-in-ncm_bitrate.patch queue-4.19/serial-atmel-fix-incorrect-baudrate-setup.patch queue-4.19/prlimit-do_prlimit-needs-to-have-a-speculation-check.patch queue-4.19/usb-gadget-g_webcam-send-color-matching-descriptor-per-frame.patch queue-4.19/usb-serial-option-add-quectel-em05cn-sg-modem.patch queue-4.19/usb-storage-apply-ignore_uas-only-for-hiksemi-md202-on-rtl9210.patch queue-4.19/xhci-add-a-flag-to-disable-usb3-lpm-on-a-xhci-root-port-level.patch queue-4.19/cifs-do-not-include-page-data-when-checking-signature.patch queue-4.19/gsmi-fix-null-deref-in-gsmi_get_variable.patch queue-4.19/revert-ext4-generalize-extents-status-tree-search-functions.patch