Patch "af_unix: selftest: Fix the size of the parameter to connect()" has been added to the 5.15-stable tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This is a note to let you know that I've just added the patch titled

    af_unix: selftest: Fix the size of the parameter to connect()

to the 5.15-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     af_unix-selftest-fix-the-size-of-the-parameter-to-co.patch
and it can be found in the queue-5.15 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.



commit 88dc589c7a16d6678a8a8c7d4838e40e0b66667f
Author: Mirsad Goran Todorovac <mirsad.todorovac@xxxxxxxxxxxx>
Date:   Sat Jan 7 04:40:20 2023 +0100

    af_unix: selftest: Fix the size of the parameter to connect()
    
    [ Upstream commit 7d6ceeb1875cc08dc3d1e558e191434d94840cd5 ]
    
    Adjust size parameter in connect() to match the type of the parameter, to
    fix "No such file or directory" error in selftests/net/af_unix/
    test_oob_unix.c:127.
    
    The existing code happens to work provided that the autogenerated pathname
    is shorter than sizeof (struct sockaddr), which is why it hasn't been
    noticed earlier.
    
    Visible from the trace excerpt:
    
    bind(3, {sa_family=AF_UNIX, sun_path="unix_oob_453059"}, 110) = 0
    clone(child_stack=NULL, flags=CLONE_CHILD_CLEARTID|CLONE_CHILD_SETTID|SIGCHLD, child_tidptr=0x7fa6a6577a10) = 453060
    [pid <child>] connect(6, {sa_family=AF_UNIX, sun_path="unix_oob_45305"}, 16) = -1 ENOENT (No such file or directory)
    
    BUG: The filename is trimmed to sizeof (struct sockaddr).
    
    Cc: "David S. Miller" <davem@xxxxxxxxxxxxx>
    Cc: Eric Dumazet <edumazet@xxxxxxxxxx>
    Cc: Jakub Kicinski <kuba@xxxxxxxxxx>
    Cc: Paolo Abeni <pabeni@xxxxxxxxxx>
    Cc: Shuah Khan <shuah@xxxxxxxxxx>
    Cc: Kuniyuki Iwashima <kuniyu@xxxxxxxxxxxx>
    Cc: Florian Westphal <fw@xxxxxxxxx>
    Reviewed-by: Florian Westphal <fw@xxxxxxxxx>
    Fixes: 314001f0bf92 ("af_unix: Add OOB support")
    Signed-off-by: Mirsad Goran Todorovac <mirsad.todorovac@xxxxxxxxxxxx>
    Reviewed-by: Kuniyuki Iwashima <kuniyu@xxxxxxxxxx>
    Signed-off-by: David S. Miller <davem@xxxxxxxxxxxxx>
    Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>

diff --git a/tools/testing/selftests/net/af_unix/test_unix_oob.c b/tools/testing/selftests/net/af_unix/test_unix_oob.c
index b57e91e1c3f2..532459a15067 100644
--- a/tools/testing/selftests/net/af_unix/test_unix_oob.c
+++ b/tools/testing/selftests/net/af_unix/test_unix_oob.c
@@ -124,7 +124,7 @@ void producer(struct sockaddr_un *consumer_addr)
 
 	wait_for_signal(pipefd[0]);
 	if (connect(cfd, (struct sockaddr *)consumer_addr,
-		     sizeof(struct sockaddr)) != 0) {
+		     sizeof(*consumer_addr)) != 0) {
 		perror("Connect failed");
 		kill(0, SIGTERM);
 		exit(1);



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux