This is a note to let you know that I've just added the patch titled driver core: Fix bus_type.match() error handling in __driver_attach() to the 4.19-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: driver-core-fix-bus_type.match-error-handling-in-__driver_attach.patch and it can be found in the queue-4.19 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let <stable@xxxxxxxxxxxxxxx> know about it. >From 27c0d217340e47ec995557f61423ef415afba987 Mon Sep 17 00:00:00 2001 From: "Isaac J. Manjarres" <isaacmanjarres@xxxxxxxxxx> Date: Tue, 20 Sep 2022 17:14:13 -0700 Subject: driver core: Fix bus_type.match() error handling in __driver_attach() From: Isaac J. Manjarres <isaacmanjarres@xxxxxxxxxx> commit 27c0d217340e47ec995557f61423ef415afba987 upstream. When a driver registers with a bus, it will attempt to match with every device on the bus through the __driver_attach() function. Currently, if the bus_type.match() function encounters an error that is not -EPROBE_DEFER, __driver_attach() will return a negative error code, which causes the driver registration logic to stop trying to match with the remaining devices on the bus. This behavior is not correct; a failure while matching a driver to a device does not mean that the driver won't be able to match and bind with other devices on the bus. Update the logic in __driver_attach() to reflect this. Fixes: 656b8035b0ee ("ARM: 8524/1: driver cohandle -EPROBE_DEFER from bus_type.match()") Cc: stable@xxxxxxxxxxxxxxx Cc: Saravana Kannan <saravanak@xxxxxxxxxx> Signed-off-by: Isaac J. Manjarres <isaacmanjarres@xxxxxxxxxx> Link: https://lore.kernel.org/r/20220921001414.4046492-1-isaacmanjarres@xxxxxxxxxx Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> --- drivers/base/dd.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) --- a/drivers/base/dd.c +++ b/drivers/base/dd.c @@ -911,8 +911,12 @@ static int __driver_attach(struct device */ return 0; } else if (ret < 0) { - dev_dbg(dev, "Bus failed to match device: %d", ret); - return ret; + dev_dbg(dev, "Bus failed to match device: %d\n", ret); + /* + * Driver could not match with device, but may match with + * another device on the bus. + */ + return 0; } /* ret > 0 means positive match */ if (dev->parent && dev->bus->need_parent_lock) Patches currently in stable-queue which might be from isaacmanjarres@xxxxxxxxxx are queue-4.19/driver-core-fix-bus_type.match-error-handling-in-__driver_attach.patch