Patch "net/mlx5e: IPoIB, Don't allow CQE compression to be turned on by default" has been added to the 5.10-stable tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This is a note to let you know that I've just added the patch titled

    net/mlx5e: IPoIB, Don't allow CQE compression to be turned on by default

to the 5.10-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     net-mlx5e-ipoib-don-t-allow-cqe-compression-to-be-tu.patch
and it can be found in the queue-5.10 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.



commit 1d33b28a01796b6437dcccdcc70f4cc7e3f3b8a7
Author: Dragos Tatulea <dtatulea@xxxxxxxxxx>
Date:   Mon Nov 28 15:24:21 2022 +0200

    net/mlx5e: IPoIB, Don't allow CQE compression to be turned on by default
    
    [ Upstream commit b12d581e83e3ae1080c32ab83f123005bd89a840 ]
    
    mlx5e_build_nic_params will turn CQE compression on if the hardware
    capability is enabled and the slow_pci_heuristic condition is detected.
    As IPoIB doesn't support CQE compression, make sure to disable the
    feature in the IPoIB profile init.
    
    Please note that the feature is not exposed to the user for IPoIB
    interfaces, so it can't be subsequently turned on.
    
    Fixes: b797a684b0dd ("net/mlx5e: Enable CQE compression when PCI is slower than link")
    Signed-off-by: Dragos Tatulea <dtatulea@xxxxxxxxxx>
    Reviewed-by: Gal Pressman <gal@xxxxxxxxxx>
    Signed-off-by: Saeed Mahameed <saeedm@xxxxxxxxxx>
    Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>

diff --git a/drivers/net/ethernet/mellanox/mlx5/core/ipoib/ipoib.c b/drivers/net/ethernet/mellanox/mlx5/core/ipoib/ipoib.c
index 5c6a376aa62e..0e7fd200b426 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/ipoib/ipoib.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/ipoib/ipoib.c
@@ -69,6 +69,10 @@ static void mlx5i_build_nic_params(struct mlx5_core_dev *mdev,
 	params->lro_en = false;
 	params->hard_mtu = MLX5_IB_GRH_BYTES + MLX5_IPOIB_HARD_LEN;
 	params->tunneled_offload_en = false;
+
+	/* CQE compression is not supported for IPoIB */
+	params->rx_cqe_compress_def = false;
+	MLX5E_SET_PFLAG(params, MLX5E_PFLAG_RX_CQE_COMPRESS, params->rx_cqe_compress_def);
 }
 
 /* Called directly after IPoIB netdevice was created to initialize SW structs */



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux