This is a note to let you know that I've just added the patch titled ext4: fix inode leak in ext4_xattr_inode_create() on an error path to the 5.15-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: ext4-fix-inode-leak-in-ext4_xattr_inode_create-on-an-error-path.patch and it can be found in the queue-5.15 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let <stable@xxxxxxxxxxxxxxx> know about it. >From e4db04f7d3dbbe16680e0ded27ea2a65b10f766a Mon Sep 17 00:00:00 2001 From: Ye Bin <yebin10@xxxxxxxxxx> Date: Thu, 8 Dec 2022 10:32:33 +0800 Subject: ext4: fix inode leak in ext4_xattr_inode_create() on an error path From: Ye Bin <yebin10@xxxxxxxxxx> commit e4db04f7d3dbbe16680e0ded27ea2a65b10f766a upstream. There is issue as follows when do setxattr with inject fault: [localhost]# fsck.ext4 -fn /dev/sda e2fsck 1.46.6-rc1 (12-Sep-2022) Pass 1: Checking inodes, blocks, and sizes Pass 2: Checking directory structure Pass 3: Checking directory connectivity Pass 4: Checking reference counts Unattached zero-length inode 15. Clear? no Unattached inode 15 Connect to /lost+found? no Pass 5: Checking group summary information /dev/sda: ********** WARNING: Filesystem still has errors ********** /dev/sda: 15/655360 files (0.0% non-contiguous), 66755/2621440 blocks This occurs in 'ext4_xattr_inode_create()'. If 'ext4_mark_inode_dirty()' fails, dropping i_nlink of the inode is needed. Or will lead to inode leak. Signed-off-by: Ye Bin <yebin10@xxxxxxxxxx> Reviewed-by: Jan Kara <jack@xxxxxxx> Link: https://lore.kernel.org/r/20221208023233.1231330-5-yebin@xxxxxxxxxxxxxxx Signed-off-by: Theodore Ts'o <tytso@xxxxxxx> Cc: stable@xxxxxxxxxx Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> --- fs/ext4/xattr.c | 3 +++ 1 file changed, 3 insertions(+) --- a/fs/ext4/xattr.c +++ b/fs/ext4/xattr.c @@ -1441,6 +1441,9 @@ static struct inode *ext4_xattr_inode_cr if (!err) err = ext4_inode_attach_jinode(ea_inode); if (err) { + if (ext4_xattr_inode_dec_ref(handle, ea_inode)) + ext4_warning_inode(ea_inode, + "cleanup dec ref error %d", err); iput(ea_inode); return ERR_PTR(err); } Patches currently in stable-queue which might be from yebin10@xxxxxxxxxx are queue-5.15/ext4-fix-inode-leak-in-ext4_xattr_inode_create-on-an-error-path.patch queue-5.15/ext4-fix-kernel-bug-in-ext4_write_inline_data_end.patch queue-5.15/ext4-allocate-extended-attribute-value-in-vmalloc-area.patch queue-5.15/ext4-fix-uninititialized-value-in-ext4_evict_inode.patch queue-5.15/ext4-fix-reserved-cluster-accounting-in-__es_remove_extent.patch queue-5.15/ext4-init-quota-for-old.inode-in-ext4_rename.patch