Patch "USB: bcma: Add a check for devm_gpiod_get" has been added to the 5.4-stable tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This is a note to let you know that I've just added the patch titled

    USB: bcma: Add a check for devm_gpiod_get

to the 5.4-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     usb-bcma-add-a-check-for-devm_gpiod_get.patch
and it can be found in the queue-5.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.



commit b9ea1129368b877a7143b714b7e09b6820a28000
Author: Chuhong Yuan <hslester96@xxxxxxxxx>
Date:   Wed Oct 16 16:35:32 2019 +0800

    USB: bcma: Add a check for devm_gpiod_get
    
    [ Upstream commit f3de5d857bb2362b00e2a8d4bc886cd49dcb66db ]
    
    bcma_hcd_probe misses a check for devm_gpiod_get and may miss
    the error.
    Add a check for it and return the error if a failure occurs.
    
    Signed-off-by: Chuhong Yuan <hslester96@xxxxxxxxx>
    Link: https://lore.kernel.org/r/20191016083531.5734-1-hslester96@xxxxxxxxx
    Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
    Stable-dep-of: cd136706b4f9 ("USB: bcma: Make GPIO explicitly optional")
    Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>

diff --git a/drivers/usb/host/bcma-hcd.c b/drivers/usb/host/bcma-hcd.c
index 2400a826397a..652fa29beb27 100644
--- a/drivers/usb/host/bcma-hcd.c
+++ b/drivers/usb/host/bcma-hcd.c
@@ -406,9 +406,12 @@ static int bcma_hcd_probe(struct bcma_device *core)
 		return -ENOMEM;
 	usb_dev->core = core;
 
-	if (core->dev.of_node)
+	if (core->dev.of_node) {
 		usb_dev->gpio_desc = devm_gpiod_get(&core->dev, "vcc",
 						    GPIOD_OUT_HIGH);
+		if (IS_ERR(usb_dev->gpio_desc))
+			return PTR_ERR(usb_dev->gpio_desc);
+	}
 
 	switch (core->id.id) {
 	case BCMA_CORE_USB20_HOST:



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux