This is a note to let you know that I've just added the patch titled
dmaengine: at_hdmac: Fix concurrency over descriptor
to the 5.15-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
dmaengine-at_hdmac-fix-concurrency-over-descriptor.patch
and it can be found in the queue-5.15 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.
>From 06988949df8c3007ad82036d3606d8ae72ed9000 Mon Sep 17 00:00:00 2001
From: Tudor Ambarus <tudor.ambarus@xxxxxxxxxxxxx>
Date: Tue, 25 Oct 2022 12:02:42 +0300
Subject: dmaengine: at_hdmac: Fix concurrency over descriptor
From: Tudor Ambarus <tudor.ambarus@xxxxxxxxxxxxx>
commit 06988949df8c3007ad82036d3606d8ae72ed9000 upstream.
The descriptor was added to the free_list before calling the callback,
which could result in reissuing of the same descriptor and calling of a
single callback for both. Move the decriptor to the free list after the
callback is invoked.
Fixes: dc78baa2b90b ("dmaengine: at_hdmac: new driver for the Atmel AHB DMA Controller")
Reported-by: Peter Rosin <peda@xxxxxxxxxx>
Signed-off-by: Tudor Ambarus <tudor.ambarus@xxxxxxxxxxxxx>
Cc: stable@xxxxxxxxxxxxxxx
Link: https://lore.kernel.org/lkml/13c6c9a2-6db5-c3bf-349b-4c127ad3496a@xxxxxxxxxx/
Acked-by: Nicolas Ferre <nicolas.ferre@xxxxxxxxxxxxx>
Link: https://lore.kernel.org/r/20221025090306.297886-1-tudor.ambarus@xxxxxxxxxxxxx
Link: https://lore.kernel.org/r/20221025090306.297886-9-tudor.ambarus@xxxxxxxxxxxxx
Signed-off-by: Vinod Koul <vkoul@xxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
---
drivers/dma/at_hdmac.c | 14 +++++++++-----
1 file changed, 9 insertions(+), 5 deletions(-)
--- a/drivers/dma/at_hdmac.c
+++ b/drivers/dma/at_hdmac.c
@@ -469,11 +469,8 @@ atc_chain_complete(struct at_dma_chan *a
desc->memset_buffer = false;
}
- /* move children to free_list */
- list_splice_init(&desc->tx_list, &atchan->free_list);
- /* move myself to free_list */
- list_move(&desc->desc_node, &atchan->free_list);
-
+ /* Remove transfer node from the active list. */
+ list_del_init(&desc->desc_node);
spin_unlock_irqrestore(&atchan->lock, flags);
dma_descriptor_unmap(txd);
@@ -483,6 +480,13 @@ atc_chain_complete(struct at_dma_chan *a
dmaengine_desc_get_callback_invoke(txd, NULL);
dma_run_dependencies(txd);
+
+ spin_lock_irqsave(&atchan->lock, flags);
+ /* move children to free_list */
+ list_splice_init(&desc->tx_list, &atchan->free_list);
+ /* add myself to free_list */
+ list_add(&desc->desc_node, &atchan->free_list);
+ spin_unlock_irqrestore(&atchan->lock, flags);
}
/**
Patches currently in stable-queue which might be from tudor.ambarus@xxxxxxxxxxxxx are
queue-5.15/dmaengine-at_hdmac-fix-concurrency-problems-by-removing-atc_complete_all.patch
queue-5.15/dmaengine-at_hdmac-start-transfer-for-cyclic-channels-in-issue_pending.patch
queue-5.15/dmaengine-at_hdmac-don-t-start-transactions-at-tx_submit-level.patch
queue-5.15/dmaengine-at_hdmac-fix-at_lli-struct-definition.patch
queue-5.15/dmaengine-at_hdmac-fix-descriptor-handling-when-issuing-it-to-hardware.patch
queue-5.15/dmaengine-at_hdmac-free-the-memset-buf-without-holding-the-chan-lock.patch
queue-5.15/dmaengine-at_hdmac-fix-concurrency-over-the-active-list.patch
queue-5.15/dmaengine-at_hdmac-fix-premature-completion-of-desc-in-issue_pending.patch
queue-5.15/dmaengine-at_hdmac-fix-impossible-condition.patch
queue-5.15/dmaengine-at_hdmac-check-return-code-of-dma_async_device_register.patch
queue-5.15/dmaengine-at_hdmac-don-t-allow-cpu-to-reorder-channel-enable.patch
queue-5.15/dmaengine-at_hdmac-fix-concurrency-over-descriptor.patch
queue-5.15/dmaengine-at_hdmac-protect-atchan-status-with-the-channel-lock.patch
queue-5.15/dmaengine-at_hdmac-fix-completion-of-unissued-descriptor-in-case-of-errors.patch
queue-5.15/dmaengine-at_hdmac-do-not-call-the-complete-callback-on-device_terminate_all.patch
