This is a note to let you know that I've just added the patch titled xfs: Add the missed xfs_perag_put() for xfs_ifree_cluster() to the 5.4-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: xfs-add-the-missed-xfs_perag_put-for-xfs_ifree_cluster.patch and it can be found in the queue-5.4 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let <stable@xxxxxxxxxxxxxxx> know about it. >From foo@baz Mon Nov 7 09:49:06 AM CET 2022 From: Chandan Babu R <chandan.babu@xxxxxxxxxx> Date: Mon, 7 Nov 2022 09:33:27 +0530 Subject: xfs: Add the missed xfs_perag_put() for xfs_ifree_cluster() To: gregkh@xxxxxxxxxxxxxxxxxxx Cc: sashal@xxxxxxxxxx, mcgrof@xxxxxxxxxx, linux-xfs@xxxxxxxxxxxxxxx, stable@xxxxxxxxxxxxxxx, djwong@xxxxxxxxxx, chandan.babu@xxxxxxxxxx, amir73il@xxxxxxxxx, leah.rumancik@xxxxxxxxx Message-ID: <20221107040327.132719-7-chandan.babu@xxxxxxxxxx> From: Chuhong Yuan <hslester96@xxxxxxxxx> commit 8cc0072469723459dc6bd7beff81b2b3149f4cf4 upstream. xfs_ifree_cluster() calls xfs_perag_get() at the beginning, but forgets to call xfs_perag_put() in one failed path. Add the missed function call to fix it. Fixes: ce92464c180b ("xfs: make xfs_trans_get_buf return an error code") Signed-off-by: Chuhong Yuan <hslester96@xxxxxxxxx> Reviewed-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx> Signed-off-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx> Acked-by: Darrick J. Wong <djwong@xxxxxxxxxx> Signed-off-by: Chandan Babu R <chandan.babu@xxxxxxxxxx> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> --- fs/xfs/xfs_inode.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) --- a/fs/xfs/xfs_inode.c +++ b/fs/xfs/xfs_inode.c @@ -2592,8 +2592,10 @@ xfs_ifree_cluster( mp->m_bsize * igeo->blocks_per_cluster, XBF_UNMAPPED); - if (!bp) + if (!bp) { + xfs_perag_put(pag); return -ENOMEM; + } /* * This buffer may not have been correctly initialised as we Patches currently in stable-queue which might be from chandan.babu@xxxxxxxxxx are queue-5.4/xfs-gut-error-handling-in-xfs_trans_unreserve_and_mod_sb.patch queue-5.4/xfs-add-the-missed-xfs_perag_put-for-xfs_ifree_cluster.patch queue-5.4/xfs-don-t-fail-verifier-on-empty-attr3-leaf-block.patch queue-5.4/xfs-group-quota-should-return-edquot-when-prj-quota-enabled.patch queue-5.4/xfs-use-ordered-buffers-to-initialize-dquot-buffers-during-quotacheck.patch queue-5.4/xfs-don-t-fail-unwritten-extent-conversion-on-writeback-due-to-edquot.patch