Patch "arm64: dts: exynos: fix polarity of "enable" line of NFC chip in TM2" has been added to the 6.0-stable tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This is a note to let you know that I've just added the patch titled

    arm64: dts: exynos: fix polarity of "enable" line of NFC chip in TM2

to the 6.0-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     arm64-dts-exynos-fix-polarity-of-enable-line-of-nfc-.patch
and it can be found in the queue-6.0 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.



commit 843d764dbb26173a59f14db9c3cd12ed3751638e
Author: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>
Date:   Wed Sep 28 18:15:55 2022 -0700

    arm64: dts: exynos: fix polarity of "enable" line of NFC chip in TM2
    
    [ Upstream commit bd1a665a01b4d65fd8dc6fece4b376fa5c8c55bb ]
    
    According to s3fwrn5 driver code the "enable" GPIO line is driven "high"
    when chip is not in use (mode is S3FWRN5_MODE_COLD), and is driven "low"
    when chip is in use.
    
    s3fwrn5_phy_power_ctrl():
    
            ...
            gpio_set_value(phy->gpio_en, 1);
            ...
            if (mode != S3FWRN5_MODE_COLD) {
                    msleep(S3FWRN5_EN_WAIT_TIME);
                    gpio_set_value(phy->gpio_en, 0);
                    msleep(S3FWRN5_EN_WAIT_TIME);
            }
    
    Therefore the line described by "en-gpios" property should be annotated
    as "active low".
    
    The wakeup gpio appears to have correct polarity (active high).
    
    Signed-off-by: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>
    Link: https://lore.kernel.org/r/20220929011557.4165216-1-dmitry.torokhov@xxxxxxxxx
    Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
    Stable-dep-of: a08137bd1e0a ("ARM: dts: exynos: fix polarity of VBUS GPIO of Origen")
    Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>

diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
index 91c9bd1b47dd..bde6a6bb8dfc 100644
--- a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
+++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
@@ -795,7 +795,7 @@
 		reg = <0x27>;
 		interrupt-parent = <&gpa1>;
 		interrupts = <3 IRQ_TYPE_EDGE_RISING>;
-		en-gpios = <&gpf1 4 GPIO_ACTIVE_HIGH>;
+		en-gpios = <&gpf1 4 GPIO_ACTIVE_LOW>;
 		wake-gpios = <&gpj0 2 GPIO_ACTIVE_HIGH>;
 	};
 };



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux