On Mon, Sep 26, 2022 at 10:00:17AM +0200, Arnd Bergmann wrote:
On Mon, Sep 26, 2022, at 4:50 AM, Sasha Levin wrote:
On Sun, Sep 25, 2022 at 09:58:18PM +0200, Arnd Bergmann wrote:
I didn't end up taking 5641c751fe2f so you're right - I'm going to drop
b0e99d03778 too.
Ok, thanks. I'm still confused about the rest of my series though:
While a76053707dbf does depend on the ones before it (and more I think),
5641c751fe2f should not have a dependency on a76053707dbf, right?
It does, because the following two hunks from a76053707dbf:
};
Are needed by following ones from 5641c751fe2f:
diff --git a/drivers/net/ethernet/freescale/enetc/enetc_vf.c
b/drivers/net/ethernet/freescale/enetc/enetc_vf.c
index 4048101c42be..dfcaac302e24 100644
--- a/drivers/net/ethernet/freescale/enetc/enetc_vf.c
+++ b/drivers/net/ethernet/freescale/enetc/enetc_vf.c
@@ -104,3 +115,3 @@ static const struct net_device_ops enetc_ndev_ops =
{
.ndo_eth_ioctl = enetc_ioctl,
- .ndo_setup_tc = enetc_setup_tc,
+ .ndo_setup_tc = enetc_vf_setup_tc,
};
Yes, this is just context.
Ah, so mean this just got incorrectly identified as a dependency
by a script, not that you were actually considering the backport
of the context changes, right?
My workflow is to have the script attempt to identify and cherry-pick
all dependencies, marking them as such, and then I manually go over the
result and decide whether we really need the patches it picked or not.
So in theory yes, at some point this was considered for backport, but
should have been dropped during the review phase.
--
Thanks,
Sasha
