This is a note to let you know that I've just added the patch titled
raw: fix a typo in raw_icmp_error()
to the 5.19-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
raw-fix-a-typo-in-raw_icmp_error.patch
and it can be found in the queue-5.19 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.
>From 97a4d46b1516250d640c1ae0c9e7129d160d6a1c Mon Sep 17 00:00:00 2001
From: Eric Dumazet <edumazet@xxxxxxxxxx>
Date: Thu, 23 Jun 2022 19:35:40 +0000
Subject: raw: fix a typo in raw_icmp_error()
From: Eric Dumazet <edumazet@xxxxxxxxxx>
commit 97a4d46b1516250d640c1ae0c9e7129d160d6a1c upstream.
I accidentally broke IPv4 traceroute, by swapping iph->saddr
and iph->daddr.
Probably because raw_icmp_error() and raw_v4_input()
use different order for iph->saddr and iph->daddr.
Fixes: ba44f8182ec2 ("raw: use more conventional iterators")
Reported-by: John Sperbeck <jsperbeck@xxxxxxxxxx>
Signed-off-by: Eric Dumazet <edumazet@xxxxxxxxxx>
Link: https://lore.kernel.org/r/20220623193540.2851799-1-edumazet@xxxxxxxxxx
Signed-off-by: Jakub Kicinski <kuba@xxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
---
net/ipv4/raw.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/net/ipv4/raw.c
+++ b/net/ipv4/raw.c
@@ -278,7 +278,7 @@ void raw_icmp_error(struct sk_buff *skb,
hlist_nulls_for_each_entry(sk, hnode, hlist, sk_nulls_node) {
iph = (const struct iphdr *)skb->data;
if (!raw_v4_match(net, sk, iph->protocol,
- iph->saddr, iph->daddr, dif, sdif))
+ iph->daddr, iph->saddr, dif, sdif))
continue;
raw_err(sk, skb, info);
}
Patches currently in stable-queue which might be from edumazet@xxxxxxxxxx are
queue-5.19/ping-convert-to-rcu-lookups-get-rid-of-rwlock.patch
queue-5.19/batman-adv-tracing-use-the-new-__vstring-helper.patch
queue-5.19/epoll-autoremove-wakers-even-more-aggressively.patch
queue-5.19/tcp-fix-over-estimation-in-sk_forced_mem_schedule.patch
queue-5.19/tcp-fix-possible-freeze-in-tx-path-under-memory-pres.patch
queue-5.19/raw-fix-a-typo-in-raw_icmp_error.patch
queue-5.19/raw-convert-raw-sockets-to-rcu.patch
queue-5.19/raw-use-more-conventional-iterators.patch
queue-5.19/ax25-fix-incorrect-dev_tracker-usage.patch
queue-5.19/tracing-events-add-__vstring-and-__assign_vstr-helpe.patch
queue-5.19/tcp-make-retransmitted-skb-fit-into-the-send-window.patch
queue-5.19/net-rose-fix-netdev-reference-changes.patch
queue-5.19/raw-remove-unused-variables-from-raw6_icmp_error.patch
queue-5.19/net-fix-sk_wmem_schedule-and-sk_rmem_schedule-errors.patch
