Patch "HID: nintendo: Add missing array termination" has been added to the 5.19-stable tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This is a note to let you know that I've just added the patch titled

    HID: nintendo: Add missing array termination

to the 5.19-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     hid-nintendo-add-missing-array-termination.patch
and it can be found in the queue-5.19 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.



commit fda2e32fadf0b81d5d65e6535b400165619be6c8
Author: Guenter Roeck <linux@xxxxxxxxxxxx>
Date:   Tue Jul 12 15:17:05 2022 -0700

    HID: nintendo: Add missing array termination
    
    [ Upstream commit ab5f3404b7762b88403fbddbdda6b1b464bd6cbc ]
    
    joycon_dpad_inputs_jc[] is unterminated. This may result in odd warnings
    such as
    
    input: input_set_capability: invalid code 3077588140 for type 1
    
    or in kernel crashes in nintendo_hid_probe(). Terminate the array to fix
    the problem.
    
    Fixes: 2af16c1f846bd ("HID: nintendo: add nintendo switch controller driver")
    Cc: Daniel J. Ogorchock <djogorchock@xxxxxxxxx>
    Signed-off-by: Guenter Roeck <linux@xxxxxxxxxxxx>
    Reviewed-by: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>
    Cc: stable@xxxxxxxxxxxxxxx
    Signed-off-by: Jiri Kosina <jkosina@xxxxxxx>
    Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>

diff --git a/drivers/hid/hid-nintendo.c b/drivers/hid/hid-nintendo.c
index 2204de889739..4b1173957c17 100644
--- a/drivers/hid/hid-nintendo.c
+++ b/drivers/hid/hid-nintendo.c
@@ -1586,6 +1586,7 @@ static const unsigned int joycon_button_inputs_r[] = {
 /* We report joy-con d-pad inputs as buttons and pro controller as a hat. */
 static const unsigned int joycon_dpad_inputs_jc[] = {
 	BTN_DPAD_UP, BTN_DPAD_DOWN, BTN_DPAD_LEFT, BTN_DPAD_RIGHT,
+	0 /* 0 signals end of array */
 };
 
 static int joycon_input_create(struct joycon_ctlr *ctlr)



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux