Patch "iio: fix iio_format_avail_range() printing for none IIO_VAL_INT" has been added to the 5.19-stable tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This is a note to let you know that I've just added the patch titled

    iio: fix iio_format_avail_range() printing for none IIO_VAL_INT

to the 5.19-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     iio-fix-iio_format_avail_range-printing-for-none-iio.patch
and it can be found in the queue-5.19 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.



commit 574bac6c5e4c8f3d6063039b1d9b4d006a170357
Author: Fawzi Khaber <fawzi.khaber@xxxxxxx>
Date:   Mon Jul 18 15:07:06 2022 +0200

    iio: fix iio_format_avail_range() printing for none IIO_VAL_INT
    
    [ Upstream commit 5e1f91850365de55ca74945866c002fda8f00331 ]
    
    iio_format_avail_range() should print range as follow [min, step, max], so
    the function was previously calling iio_format_list() with length = 3,
    length variable refers to the array size of values not the number of
    elements. In case of non IIO_VAL_INT values each element has integer part
    and decimal part. With length = 3 this would cause premature end of loop
    and result in printing only one element.
    
    Signed-off-by: Fawzi Khaber <fawzi.khaber@xxxxxxx>
    Signed-off-by: Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@xxxxxxx>
    Fixes: eda20ba1e25e ("iio: core: Consolidate iio_format_avail_{list,range}()")
    Link: https://lore.kernel.org/r/20220718130706.32571-1-jmaneyrol@xxxxxxxxxxxxxx
    Cc: <Stable@xxxxxxxxxxxxxxx>
    Signed-off-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>
    Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>

diff --git a/drivers/iio/industrialio-core.c b/drivers/iio/industrialio-core.c
index adf054c7a75e..299ae3ad2fe5 100644
--- a/drivers/iio/industrialio-core.c
+++ b/drivers/iio/industrialio-core.c
@@ -835,7 +835,23 @@ static ssize_t iio_format_avail_list(char *buf, const int *vals,
 
 static ssize_t iio_format_avail_range(char *buf, const int *vals, int type)
 {
-	return iio_format_list(buf, vals, type, 3, "[", "]");
+	int length;
+
+	/*
+	 * length refers to the array size , not the number of elements.
+	 * The purpose is to print the range [min , step ,max] so length should
+	 * be 3 in case of int, and 6 for other types.
+	 */
+	switch (type) {
+	case IIO_VAL_INT:
+		length = 3;
+		break;
+	default:
+		length = 6;
+		break;
+	}
+
+	return iio_format_list(buf, vals, type, length, "[", "]");
 }
 
 static ssize_t iio_read_channel_info_avail(struct device *dev,



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux