This is a note to let you know that I've just added the patch titled
tcp: Fix a data-race around sysctl_tcp_nometrics_save.
to the 5.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
tcp-fix-a-data-race-around-sysctl_tcp_nometrics_save.patch
and it can be found in the queue-5.4 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.
>From 8499a2454d9e8a55ce616ede9f9580f36fd5b0f3 Mon Sep 17 00:00:00 2001
From: Kuniyuki Iwashima <kuniyu@xxxxxxxxxx>
Date: Wed, 20 Jul 2022 09:50:16 -0700
Subject: tcp: Fix a data-race around sysctl_tcp_nometrics_save.
From: Kuniyuki Iwashima <kuniyu@xxxxxxxxxx>
commit 8499a2454d9e8a55ce616ede9f9580f36fd5b0f3 upstream.
While reading sysctl_tcp_nometrics_save, it can be changed concurrently.
Thus, we need to add READ_ONCE() to its reader.
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Kuniyuki Iwashima <kuniyu@xxxxxxxxxx>
Signed-off-by: David S. Miller <davem@xxxxxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
---
net/ipv4/tcp_metrics.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/net/ipv4/tcp_metrics.c
+++ b/net/ipv4/tcp_metrics.c
@@ -329,7 +329,7 @@ void tcp_update_metrics(struct sock *sk)
int m;
sk_dst_confirm(sk);
- if (net->ipv4.sysctl_tcp_nometrics_save || !dst)
+ if (READ_ONCE(net->ipv4.sysctl_tcp_nometrics_save) || !dst)
return;
rcu_read_lock();
Patches currently in stable-queue which might be from kuniyu@xxxxxxxxxx are
queue-5.4/tcp-fix-a-data-race-around-sysctl_tcp_app_win.patch
queue-5.4/tcp-fix-a-data-race-around-sysctl_tcp_nometrics_save.patch
queue-5.4/tcp-fix-a-data-race-around-sysctl_tcp_adv_win_scale.patch
queue-5.4/tcp-fix-a-data-race-around-sysctl_tcp_frto.patch
queue-5.4/tcp-fix-data-races-around-sysctl_tcp_dsack.patch
