This is a note to let you know that I've just added the patch titled
cxl/mbox: Use __le32 in get,set_lsa mailbox structures
to the 5.18-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
cxl-mbox-use-__le32-in-get-set_lsa-mailbox-structures.patch
and it can be found in the queue-5.18 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.
>From 8a66487506161dbc1d22fd154d2de0244e232040 Mon Sep 17 00:00:00 2001
From: Alison Schofield <alison.schofield@xxxxxxxxx>
Date: Fri, 25 Feb 2022 14:14:56 -0800
Subject: cxl/mbox: Use __le32 in get,set_lsa mailbox structures
From: Alison Schofield <alison.schofield@xxxxxxxxx>
commit 8a66487506161dbc1d22fd154d2de0244e232040 upstream.
CXL specification defines these as little endian.
Fixes: 60b8f17215de ("cxl/pmem: Translate NVDIMM label commands to CXL label commands")
Reported-by: Dan Williams <dan.j.williams@xxxxxxxxx>
Signed-off-by: Alison Schofield <alison.schofield@xxxxxxxxx>
Link: https://lore.kernel.org/r/20220225221456.1025635-1-alison.schofield@xxxxxxxxx
Signed-off-by: Dan Williams <dan.j.williams@xxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
---
drivers/cxl/cxlmem.h | 8 ++++----
drivers/cxl/pmem.c | 6 +++---
2 files changed, 7 insertions(+), 7 deletions(-)
--- a/drivers/cxl/cxlmem.h
+++ b/drivers/cxl/cxlmem.h
@@ -252,13 +252,13 @@ struct cxl_mbox_identify {
} __packed;
struct cxl_mbox_get_lsa {
- u32 offset;
- u32 length;
+ __le32 offset;
+ __le32 length;
} __packed;
struct cxl_mbox_set_lsa {
- u32 offset;
- u32 reserved;
+ __le32 offset;
+ __le32 reserved;
u8 data[];
} __packed;
--- a/drivers/cxl/pmem.c
+++ b/drivers/cxl/pmem.c
@@ -108,8 +108,8 @@ static int cxl_pmem_get_config_data(stru
return -EINVAL;
get_lsa = (struct cxl_mbox_get_lsa) {
- .offset = cmd->in_offset,
- .length = cmd->in_length,
+ .offset = cpu_to_le32(cmd->in_offset),
+ .length = cpu_to_le32(cmd->in_length),
};
rc = cxl_mbox_send_cmd(cxlds, CXL_MBOX_OP_GET_LSA, &get_lsa,
@@ -139,7 +139,7 @@ static int cxl_pmem_set_config_data(stru
return -ENOMEM;
*set_lsa = (struct cxl_mbox_set_lsa) {
- .offset = cmd->in_offset,
+ .offset = cpu_to_le32(cmd->in_offset),
};
memcpy(set_lsa->data, cmd->in_buf, cmd->in_length);
Patches currently in stable-queue which might be from alison.schofield@xxxxxxxxx are
queue-5.18/memregion-fix-memregion_free-fallback-definition.patch
queue-5.18/cxl-mbox-use-__le32-in-get-set_lsa-mailbox-structures.patch
