This is a note to let you know that I've just added the patch titled
can: mcp251xfd: mcp251xfd_register_get_dev_id(): fix endianness conversion
to the 5.18-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
can-mcp251xfd-mcp251xfd_register_get_dev_id-fix-endianness-conversion.patch
and it can be found in the queue-5.18 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.
>From 1c0e78a287e3493e22bde8553d02f3b89177eaf7 Mon Sep 17 00:00:00 2001
From: Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx>
Date: Mon, 20 Jun 2022 11:49:24 +0200
Subject: can: mcp251xfd: mcp251xfd_register_get_dev_id(): fix endianness conversion
From: Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx>
commit 1c0e78a287e3493e22bde8553d02f3b89177eaf7 upstream.
In mcp251xfd_register_get_dev_id() the device ID register is read with
handcrafted SPI transfers. As all registers, this register is in
little endian. Further it is not naturally aligned in struct
mcp251xfd_map_buf_nocrc::data. However after the transfer the register
content is converted from big endian to CPU endianness not taking care
of being unaligned.
Fix the conversion by converting from little endian to CPU endianness
taking the unaligned source into account.
Side note: So far the register content is 0x0 on all mcp251xfd
compatible chips, and is only used for an informative printk.
Link: https://lore.kernel.org/all/20220627092859.809042-1-mkl@xxxxxxxxxxxxxx
Fixes: 55e5b97f003e ("can: mcp25xxfd: add driver for Microchip MCP25xxFD SPI CAN")
Reviewed-by: Rasmus Villemoes <rasmus.villemoes@xxxxxxxxx>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx>
Signed-off-by: Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
---
drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
--- a/drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c
+++ b/drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c
@@ -12,6 +12,7 @@
// Copyright (c) 2019 Martin Sperl <kernel@xxxxxxxxxxxxxxxx>
//
+#include <asm/unaligned.h>
#include <linux/bitfield.h>
#include <linux/clk.h>
#include <linux/device.h>
@@ -1778,7 +1779,7 @@ mcp251xfd_register_get_dev_id(const stru
if (err)
goto out_kfree_buf_tx;
- *dev_id = be32_to_cpup((__be32 *)buf_rx->data);
+ *dev_id = get_unaligned_le32(buf_rx->data);
*effective_speed_hz_slow = xfer[0].effective_speed_hz;
*effective_speed_hz_fast = xfer[1].effective_speed_hz;
Patches currently in stable-queue which might be from mkl@xxxxxxxxxxxxxx are
queue-5.18/can-mcp251xfd-mcp251xfd_register_get_dev_id-fix-endianness-conversion.patch
queue-5.18/can-rcar_canfd-fix-data-transmission-failed-on-r-car-v3u.patch
queue-5.18/can-gs_usb-gs_usb_open-close-fix-memory-leak.patch
queue-5.18/can-mcp251xfd-mcp251xfd_register_get_dev_id-use-correct-length-to-read-dev_id.patch
queue-5.18/can-kvaser_usb-replace-run-time-checks-with-struct-kvaser_usb_driver_info.patch
queue-5.18/can-mcp251xfd-mcp251xfd_regmap_crc_read-update-workaround-broken-crc-on-tbc-register.patch
queue-5.18/can-kvaser_usb-kvaser_usb_leaf-fix-can-clock-frequency-regression.patch
queue-5.18/can-kvaser_usb-kvaser_usb_leaf-fix-bittiming-limits.patch
queue-5.18/can-mcp251xfd-mcp251xfd_stop-add-missing-hrtimer_cancel.patch
queue-5.18/can-grcan-grcan_probe-remove-extra-of_node_get.patch
queue-5.18/can-m_can-m_can_chip_config-actually-enable-internal-timestamping.patch
queue-5.18/can-mcp251xfd-mcp251xfd_regmap_crc_read-improve-workaround-handling-for-mcp2517fd.patch
queue-5.18/can-bcm-use-call_rcu-instead-of-costly-synchronize_rcu.patch
queue-5.18/can-m_can-m_can_-read_fifo-echo_tx_event-shift-timestamp-to-full-32-bits.patch
