On Mon, Jul 04, 2022 at 08:39:54PM +0100, Russell King (Oracle) wrote:
On Mon, Jul 04, 2022 at 01:41:44PM -0400, Sasha Levin wrote:
On Mon, Jul 04, 2022 at 06:37:50PM +0100, Matthew Wilcox wrote:
> On Mon, Jul 04, 2022 at 06:33:57PM +0100, Russell King (Oracle) wrote:
> > On Mon, Jul 04, 2022 at 04:26:49PM +0100, Matthew Wilcox wrote:
> > > On Sun, Jun 26, 2022 at 11:12:57PM -0400, Sasha Levin wrote:
> > > > This is a note to let you know that I've just added the patch titled
> > > >
> > > > vmcore: convert copy_oldmem_page() to take an iov_iter
> > > >
> > > > to the 5.18-stable tree which can be found at:
> > > > http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
> > > >
> > > > The filename of the patch is:
> > > > vmcore-convert-copy_oldmem_page-to-take-an-iov_iter.patch
> > > > and it can be found in the queue-5.18 subdirectory.
> > > >
> > > > If you, or anyone else, feels it should not be added to the stable tree,
> > > > please let <stable@xxxxxxxxxxxxxxx> know about it.
> > >
> > > I don't understand why this patch was selected for backport? It doesn't
> > > seem to fit under any of the usual stable rules.
> >
> > >From what I can tell, if you mention "fix" in the commit message, it will
> > be picked up by the stable team.
> >
> > > > commit a4562abf36d082779ada087172a916cd1ec749c7
> > > > Author: Matthew Wilcox (Oracle) <willy@xxxxxxxxxxxxx>
> > > > Date: Fri Apr 29 14:37:59 2022 -0700
> > > >
> > > > vmcore: convert copy_oldmem_page() to take an iov_iter
> > > >
> > > > [ Upstream commit 5d8de293c224896a4da99763fce4f9794308caf4 ]
> > > >
> > > > Patch series "Convert vmcore to use an iov_iter", v5.
> > > >
> > > > For some reason several people have been sending bad patches to fix
> > ^^^
> >
> > I believe that's enough to get it picked.
No, this is not the case here.
What are the criteria that are used to auto-pick patches?
There's no clean criteria here: it's an AI system that takes in multiple
inputs and based on weights it determines the probability a patch is a
fix.
Yes, the word "fix" helps a patch get included, but the AI is usually
"smart" enough to exclude things like what you've pointed out above, and
things like "typo fix", "fix ABC in comment", etc.
--
Thanks,
Sasha
