This is a note to let you know that I've just added the patch titled
9p: fix fid refcount leak in v9fs_vfs_atomic_open_dotl
to the 5.18-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
9p-fix-fid-refcount-leak-in-v9fs_vfs_atomic_open_dotl.patch
and it can be found in the queue-5.18 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.
>From beca774fc51a9ba8abbc869cf0c3d965ff17cd24 Mon Sep 17 00:00:00 2001
From: Dominique Martinet <asmadeus@xxxxxxxxxxxxx>
Date: Sun, 12 Jun 2022 16:00:05 +0900
Subject: 9p: fix fid refcount leak in v9fs_vfs_atomic_open_dotl
From: Dominique Martinet <asmadeus@xxxxxxxxxxxxx>
commit beca774fc51a9ba8abbc869cf0c3d965ff17cd24 upstream.
We need to release directory fid if we fail halfway through open
This fixes fid leaking with xfstests generic 531
Link: https://lkml.kernel.org/r/20220612085330.1451496-2-asmadeus@xxxxxxxxxxxxx
Fixes: 6636b6dcc3db ("9p: add refcount to p9_fid struct")
Cc: stable@xxxxxxxxxxxxxxx
Reported-by: Tyler Hicks <tyhicks@xxxxxxxxxxxxxxxxxxx>
Reviewed-by: Tyler Hicks <tyhicks@xxxxxxxxxxxxxxxxxxx>
Reviewed-by: Christian Schoenebeck <linux_oss@xxxxxxxxxxxxx>
Signed-off-by: Dominique Martinet <asmadeus@xxxxxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
---
fs/9p/vfs_inode_dotl.c | 3 +++
1 file changed, 3 insertions(+)
--- a/fs/9p/vfs_inode_dotl.c
+++ b/fs/9p/vfs_inode_dotl.c
@@ -274,6 +274,7 @@ v9fs_vfs_atomic_open_dotl(struct inode *
if (IS_ERR(ofid)) {
err = PTR_ERR(ofid);
p9_debug(P9_DEBUG_VFS, "p9_client_walk failed %d\n", err);
+ p9_client_clunk(dfid);
goto out;
}
@@ -285,6 +286,7 @@ v9fs_vfs_atomic_open_dotl(struct inode *
if (err) {
p9_debug(P9_DEBUG_VFS, "Failed to get acl values in creat %d\n",
err);
+ p9_client_clunk(dfid);
goto error;
}
err = p9_client_create_dotl(ofid, name, v9fs_open_to_dotl_flags(flags),
@@ -292,6 +294,7 @@ v9fs_vfs_atomic_open_dotl(struct inode *
if (err < 0) {
p9_debug(P9_DEBUG_VFS, "p9_client_open_dotl failed in creat %d\n",
err);
+ p9_client_clunk(dfid);
goto error;
}
v9fs_invalidate_inode_attr(dir);
Patches currently in stable-queue which might be from asmadeus@xxxxxxxxxxxxx are
queue-5.18/9p-fix-fid-refcount-leak-in-v9fs_vfs_atomic_open_dotl.patch
queue-5.18/9p-fix-fid-refcount-leak-in-v9fs_vfs_get_link.patch
queue-5.18/9p-fix-refcounting-during-full-path-walks-for-fid-lookups.patch
queue-5.18/9p-fix-ebadf-errors-in-cached-mode.patch
