This is a note to let you know that I've just added the patch titled
linux/random.h: Mark CONFIG_ARCH_RANDOM functions __must_check
to the 4.19-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
linux-random.h-mark-config_arch_random-functions-__must_check.patch
and it can be found in the queue-4.19 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.
>From foo@baz Fri Jun 17 08:58:56 AM CEST 2022
From: Richard Henderson <richard.henderson@xxxxxxxxxx>
Date: Fri, 10 Jan 2020 14:54:18 +0000
Subject: linux/random.h: Mark CONFIG_ARCH_RANDOM functions __must_check
From: Richard Henderson <richard.henderson@xxxxxxxxxx>
commit 904caa6413c87aacbf7d0682da617c39ca18cf1a upstream.
We must not use the pointer output without validating the
success of the random read.
Reviewed-by: Ard Biesheuvel <ardb@xxxxxxxxxx>
Signed-off-by: Richard Henderson <rth@xxxxxxxxxxx>
Signed-off-by: Mark Brown <broonie@xxxxxxxxxx>
Link: https://lore.kernel.org/r/20200110145422.49141-7-broonie@xxxxxxxxxx
Signed-off-by: Theodore Ts'o <tytso@xxxxxxx>
Signed-off-by: Jason A. Donenfeld <Jason@xxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
---
include/linux/random.h | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
--- a/include/linux/random.h
+++ b/include/linux/random.h
@@ -118,19 +118,19 @@ unsigned long randomize_page(unsigned lo
#ifdef CONFIG_ARCH_RANDOM
# include <asm/archrandom.h>
#else
-static inline bool arch_get_random_long(unsigned long *v)
+static inline bool __must_check arch_get_random_long(unsigned long *v)
{
return false;
}
-static inline bool arch_get_random_int(unsigned int *v)
+static inline bool __must_check arch_get_random_int(unsigned int *v)
{
return false;
}
-static inline bool arch_get_random_seed_long(unsigned long *v)
+static inline bool __must_check arch_get_random_seed_long(unsigned long *v)
{
return false;
}
-static inline bool arch_get_random_seed_int(unsigned int *v)
+static inline bool __must_check arch_get_random_seed_int(unsigned int *v)
{
return false;
}
Patches currently in stable-queue which might be from richard.henderson@xxxxxxxxxx are
queue-4.19/linux-random.h-remove-arch_has_random-arch_has_random_seed.patch
queue-4.19/powerpc-remove-arch_has_random-arch_has_random_seed.patch
queue-4.19/powerpc-use-bool-in-archrandom.h.patch
queue-4.19/s390-remove-arch_has_random-arch_has_random_seed.patch
queue-4.19/linux-random.h-mark-config_arch_random-functions-__must_check.patch
queue-4.19/linux-random.h-use-false-with-bool.patch
queue-4.19/x86-remove-arch_has_random-arch_has_random_seed.patch
