This is a note to let you know that I've just added the patch titled
net/sched: act_api: fix error code in tcf_ct_flow_table_fill_tuple_ipv6()
to the 5.18-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
net-sched-act_api-fix-error-code-in-tcf_ct_flow_tabl.patch
and it can be found in the queue-5.18 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.
commit 97017861e5083aeac0d0ee846461be6848d868dc
Author: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Date: Tue May 31 15:10:05 2022 +0300
net/sched: act_api: fix error code in tcf_ct_flow_table_fill_tuple_ipv6()
[ Upstream commit 86360030cc5117596626bef1d937277cd2bebe05 ]
The tcf_ct_flow_table_fill_tuple_ipv6() function is supposed to return
false on failure. It should not return negatives because that means
succes/true.
Fixes: fcb6aa86532c ("act_ct: Support GRE offload")
Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Acked-by: Toshiaki Makita <toshiaki.makita1@xxxxxxxxx>
Link: https://lore.kernel.org/r/YpYFnbDxFl6tQ3Bn@kili
Signed-off-by: Paolo Abeni <pabeni@xxxxxxxxxx>
Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>
diff --git a/net/sched/act_ct.c b/net/sched/act_ct.c
index b1f502fce595..b3ca837fd4e8 100644
--- a/net/sched/act_ct.c
+++ b/net/sched/act_ct.c
@@ -548,7 +548,7 @@ tcf_ct_flow_table_fill_tuple_ipv6(struct sk_buff *skb,
break;
#endif
default:
- return -1;
+ return false;
}
if (ip6h->hop_limit <= 1)
