Patch "init: call time_init() before rand_initialize()" has been added to the 5.18-stable tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This is a note to let you know that I've just added the patch titled

    init: call time_init() before rand_initialize()

to the 5.18-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     init-call-time_init-before-rand_initialize.patch
and it can be found in the queue-5.18 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.


>From foo@baz Thu May 26 04:17:01 PM CEST 2022
From: "Jason A. Donenfeld" <Jason@xxxxxxxxx>
Date: Thu, 5 May 2022 02:20:22 +0200
Subject: init: call time_init() before rand_initialize()

From: "Jason A. Donenfeld" <Jason@xxxxxxxxx>

commit fe222a6ca2d53c38433cba5d3be62a39099e708e upstream.

Currently time_init() is called after rand_initialize(), but
rand_initialize() makes use of the timer on various platforms, and
sometimes this timer needs to be initialized by time_init() first. In
order for random_get_entropy() to not return zero during early boot when
it's potentially used as an entropy source, reverse the order of these
two calls. The block doing random initialization was right before
time_init() before, so changing the order shouldn't have any complicated
effects.

Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
Reviewed-by: Stafford Horne <shorne@xxxxxxxxx>
Signed-off-by: Jason A. Donenfeld <Jason@xxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
---
 init/main.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

--- a/init/main.c
+++ b/init/main.c
@@ -1035,11 +1035,13 @@ asmlinkage __visible void __init __no_sa
 	softirq_init();
 	timekeeping_init();
 	kfence_init();
+	time_init();
 
 	/*
 	 * For best initial stack canary entropy, prepare it after:
 	 * - setup_arch() for any UEFI RNG entropy and boot cmdline access
 	 * - timekeeping_init() for ktime entropy used in rand_initialize()
+	 * - time_init() for making random_get_entropy() work on some platforms
 	 * - rand_initialize() to get any arch-specific entropy like RDRAND
 	 * - add_latent_entropy() to get any latent entropy
 	 * - adding command line entropy
@@ -1049,7 +1051,6 @@ asmlinkage __visible void __init __no_sa
 	add_device_randomness(command_line, strlen(command_line));
 	boot_init_stack_canary();
 
-	time_init();
 	perf_event_init();
 	profile_init();
 	call_function_init();


Patches currently in stable-queue which might be from Jason@xxxxxxxxx are

queue-5.18/random-remove-ratelimiting-for-in-kernel-unseeded-randomness.patch
queue-5.18/random-fix-sysctl-documentation-nits.patch
queue-5.18/random-help-compiler-out-with-fast_mix-by-using-simpler-arguments.patch
queue-5.18/siphash-use-one-source-of-truth-for-siphash-permutations.patch
queue-5.18/um-use-fallback-for-random_get_entropy-instead-of-zero.patch
queue-5.18/random-order-timer-entropy-functions-below-interrupt-functions.patch
queue-5.18/random-unify-batched-entropy-implementations.patch
queue-5.18/random-make-consistent-use-of-buf-and-len.patch
queue-5.18/random-move-randomize_page-into-mm-where-it-belongs.patch
queue-5.18/random-use-first-128-bits-of-input-as-fast-init.patch
queue-5.18/random-use-proper-return-types-on-get_random_-int-long-_wait.patch
queue-5.18/s390-define-get_cycles-macro-for-arch-override.patch
queue-5.18/timekeeping-add-raw-clock-fallback-for-random_get_entropy.patch
queue-5.18/random-use-static-branch-for-crng_ready.patch
queue-5.18/arm-use-fallback-for-random_get_entropy-instead-of-zero.patch
queue-5.18/mips-use-fallback-for-random_get_entropy-instead-of-just-c0-random.patch
queue-5.18/random-avoid-initializing-twice-in-credit-race.patch
queue-5.18/random-move-initialization-functions-out-of-hot-pages.patch
queue-5.18/random-do-not-pretend-to-handle-premature-next-security-model.patch
queue-5.18/random-do-not-use-batches-when-crng_ready.patch
queue-5.18/m68k-use-fallback-for-random_get_entropy-instead-of-zero.patch
queue-5.18/random-move-initialization-out-of-reseeding-hot-path.patch
queue-5.18/x86-tsc-use-fallback-for-random_get_entropy-instead-of-zero.patch
queue-5.18/random-credit-architectural-init-the-exact-amount.patch
queue-5.18/random-check-for-signals-after-page-of-pool-writes.patch
queue-5.18/random-remove-extern-from-functions-in-header.patch
queue-5.18/random-do-not-use-input-pool-from-hard-irqs.patch
queue-5.18/random-wire-up-fops-splice_-read-write-_iter.patch
queue-5.18/random-insist-on-random_get_entropy-existing-in-order-to-simplify.patch
queue-5.18/powerpc-define-get_cycles-macro-for-arch-override.patch
queue-5.18/parisc-define-get_cycles-macro-for-arch-override.patch
queue-5.18/sparc-use-fallback-for-random_get_entropy-instead-of-zero.patch
queue-5.18/nios2-use-fallback-for-random_get_entropy-instead-of-zero.patch
queue-5.18/init-call-time_init-before-rand_initialize.patch
queue-5.18/riscv-use-fallback-for-random_get_entropy-instead-of-zero.patch
queue-5.18/ia64-define-get_cycles-macro-for-arch-override.patch
queue-5.18/random-handle-latent-entropy-and-command-line-from-random_init.patch
queue-5.18/random-use-proper-jiffies-comparison-macro.patch
queue-5.18/alpha-define-get_cycles-macro-for-arch-override.patch
queue-5.18/random-convert-to-using-fops-read_iter.patch
queue-5.18/xtensa-use-fallback-for-random_get_entropy-instead-of-zero.patch
queue-5.18/random-use-symbolic-constants-for-crng_init-states.patch
queue-5.18/random-convert-to-using-fops-write_iter.patch



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux