This is a note to let you know that I've just added the patch titled mm: mremap: fix sign for EFAULT error return value to the 5.17-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: mm-mremap-fix-sign-for-efault-error-return-value.patch and it can be found in the queue-5.17 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let <stable@xxxxxxxxxxxxxxx> know about it. >From 7d1e6496616275f3830e2f2f91fa69a66953e95b Mon Sep 17 00:00:00 2001 From: Niels Dossche <dossche.niels@xxxxxxxxx> Date: Mon, 9 May 2022 17:34:28 -0700 Subject: mm: mremap: fix sign for EFAULT error return value From: Niels Dossche <dossche.niels@xxxxxxxxx> commit 7d1e6496616275f3830e2f2f91fa69a66953e95b upstream. The mremap syscall is supposed to return a pointer to the new virtual memory area on success, and a negative value of the error code in case of failure. Currently, EFAULT is returned when the VMA is not found, instead of -EFAULT. The users of this syscall will therefore believe the syscall succeeded in case the VMA didn't exist, as it returns a pointer to address 0xe (0xe being the value of EFAULT). Fix the sign of the error value. Link: https://lkml.kernel.org/r/20220427224439.23828-2-dossche.niels@xxxxxxxxx Fixes: 550a7d60bd5e ("mm, hugepages: add mremap() support for hugepage backed vma") Signed-off-by: Niels Dossche <dossche.niels@xxxxxxxxx> Cc: Mina Almasry <almasrymina@xxxxxxxxxx> Cc: Mike Kravetz <mike.kravetz@xxxxxxxxxx> Cc: <stable@xxxxxxxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> --- mm/mremap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/mm/mremap.c +++ b/mm/mremap.c @@ -947,7 +947,7 @@ SYSCALL_DEFINE5(mremap, unsigned long, a return -EINTR; vma = find_vma(mm, addr); if (!vma || vma->vm_start > addr) { - ret = EFAULT; + ret = -EFAULT; goto out; } Patches currently in stable-queue which might be from dossche.niels@xxxxxxxxx are queue-5.17/mm-mremap-fix-sign-for-efault-error-return-value.patch