Patch "perf tests: Fix coresight `perf test` failure." has been added to the 5.17-stable tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This is a note to let you know that I've just added the patch titled

    perf tests: Fix coresight `perf test` failure.

to the 5.17-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     perf-tests-fix-coresight-perf-test-failure.patch
and it can be found in the queue-5.17 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.



commit cd53daedc577d2ca07cb6097bd0e7e3987ce35cd
Author: Jeremy Linton <jeremy.linton@xxxxxxx>
Date:   Thu Apr 28 10:19:47 2022 -0500

    perf tests: Fix coresight `perf test` failure.
    
    [ Upstream commit 45fa7c38696bae632310c2876ba81fdfa25cc9c2 ]
    
    Currently the `perf test` always fails the coresight test like:
    
      89: Check Arm CoreSight trace data recording and synthesized samples: FAILED!
    
    That is because the test_arm_coresight.sh is attempting to SIGINT the
    parent but is using $$ rather than $PPID and it sigint's itself when
    run under the perf test framework.
    
    Since this is done in a trap clause it ends up returning a non zero
    return.
    
    Since $PPID is a bash ism and not all distros are linking /bin/sh to
    bash, the alternative parent pid lookups are uglier than just dropping
    the kill, and its not strictly needed, lets pick the simple solution and
    drop the sigint.
    
    Fixes: 133fe2e617e48ca0 ("perf tests: Improve temp file cleanup in test_arm_coresight.sh")
    Reviewed-by: James Clark <james.clark@xxxxxxx>
    Signed-off-by: Jeremy Linton <jeremy.linton@xxxxxxx>
    Cc: Alexander Shishkin <alexander.shishkin@xxxxxxxxxxxxxxx>
    Cc: Ian Rogers <irogers@xxxxxxxxxx>
    Cc: Ingo Molnar <mingo@xxxxxxxxxx>
    Cc: James Clark <james.clark@xxxxxxx>
    Cc: Jiri Olsa <jolsa@xxxxxxxxxx>
    Cc: Leo Yan <leo.yan@xxxxxxxxxx>
    Cc: Mark Rutland <mark.rutland@xxxxxxx>
    Cc: Namhyung Kim <namhyung@xxxxxxxxxx>
    Cc: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
    Jeremy Linton <jeremy.linton@xxxxxxx>
    Link: https://lore.kernel.org/r/20220428151947.290146-1-jeremy.linton@xxxxxxx
    Signed-off-by: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>
    Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>

diff --git a/tools/perf/tests/shell/test_arm_coresight.sh b/tools/perf/tests/shell/test_arm_coresight.sh
index 6de53b7ef5ff..e4cb4f1806ff 100755
--- a/tools/perf/tests/shell/test_arm_coresight.sh
+++ b/tools/perf/tests/shell/test_arm_coresight.sh
@@ -29,7 +29,6 @@ cleanup_files()
 	rm -f ${file}
 	rm -f "${perfdata}.old"
 	trap - exit term int
-	kill -2 $$
 	exit $glb_err
 }
 



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux