Patch "pps: clients: gpio: Propagate return value from pps_gpio_probe" has been added to the 5.15-stable tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This is a note to let you know that I've just added the patch titled

    pps: clients: gpio: Propagate return value from pps_gpio_probe

to the 5.15-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     pps-clients-gpio-propagate-return-value-from-pps_gpi.patch
and it can be found in the queue-5.15 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.



commit 47850e1b13348fd6ed3b08cc3427fd6e51b4d2ee
Author: Robert Hancock <robert.hancock@xxxxxxxxxx>
Date:   Wed Jan 12 14:52:14 2022 -0600

    pps: clients: gpio: Propagate return value from pps_gpio_probe
    
    [ Upstream commit abaca3179b41d4b3b115f27814ee36f6fb45e897 ]
    
    If the pps-gpio driver was probed prior to the GPIO device it uses, the
    devm_gpiod_get call returned an -EPROBE_DEFER error, but pps_gpio_probe
    replaced that error code with -EINVAL, causing the pps-gpio probe to
    fail and not be retried later. Propagate the error return value so that
    deferred probe works properly.
    
    Fixes: 161520451dfa (pps: new client driver using GPIO)
    Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
    Acked-by: Rodolfo Giometti <giometti@xxxxxxxxxxxx>
    Signed-off-by: Robert Hancock <robert.hancock@xxxxxxxxxx>
    Signed-off-by: Rodolfo Giometti <giometti@xxxxxxxxxxxx>
    Link: https://lore.kernel.org/r/20220112205214.2060954-1-robert.hancock@xxxxxxxxxx
    Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
    Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>

diff --git a/drivers/pps/clients/pps-gpio.c b/drivers/pps/clients/pps-gpio.c
index 35799e6401c9..2f4b11b4dfcd 100644
--- a/drivers/pps/clients/pps-gpio.c
+++ b/drivers/pps/clients/pps-gpio.c
@@ -169,7 +169,7 @@ static int pps_gpio_probe(struct platform_device *pdev)
 	/* GPIO setup */
 	ret = pps_gpio_setup(dev);
 	if (ret)
-		return -EINVAL;
+		return ret;
 
 	/* IRQ setup */
 	ret = gpiod_to_irq(data->gpio_pin);



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux