On Mon, Jan 24, 2022 at 10:36:39AM -0700, Nathan Chancellor wrote: > Hi Greg, > > On Mon, Jan 24, 2022 at 12:19:32PM +0100, gregkh@xxxxxxxxxxxxxxxxxxx wrote: > > > > This is a note to let you know that I've just added the patch titled > > > > lib/Kconfig.debug: make TEST_KMOD depend on PAGE_SIZE_LESS_THAN_256KB > > > > to the 5.16-stable tree which can be found at: > > http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary > > > > The filename of the patch is: > > lib-kconfig.debug-make-test_kmod-depend-on-page_size_less_than_256kb.patch > > and it can be found in the queue-5.16 subdirectory. > > > > If you, or anyone else, feels it should not be added to the stable tree, > > please let <stable@xxxxxxxxxxxxxxx> know about it. > > > > > > From bbd2e05fad3e692ff2495895975bd0fce02bdbae Mon Sep 17 00:00:00 2001 > > From: Nathan Chancellor <nathan@xxxxxxxxxx> > > Date: Wed, 19 Jan 2022 18:10:28 -0800 > > Subject: lib/Kconfig.debug: make TEST_KMOD depend on PAGE_SIZE_LESS_THAN_256KB > > > > From: Nathan Chancellor <nathan@xxxxxxxxxx> > > > > commit bbd2e05fad3e692ff2495895975bd0fce02bdbae upstream. > > > > Commit b05fbcc36be1 ("btrfs: disable build on platforms having page size > > 256K") disabled btrfs for configurations that used a 256kB page size. > > However, it did not fully solve the problem because CONFIG_TEST_KMOD > > selects CONFIG_BTRFS, which does not account for the dependency. This > > results in a Kconfig warning and the failed BUILD_BUG_ON error > > returning. > > > > WARNING: unmet direct dependencies detected for BTRFS_FS > > Depends on [n]: BLOCK [=y] && !PPC_256K_PAGES && !PAGE_SIZE_256KB [=y] > > Selected by [m]: > > - TEST_KMOD [=m] && RUNTIME_TESTING_MENU [=y] && m && MODULES [=y] && NETDEVICES [=y] && NET_CORE [=y] && INET [=y] && BLOCK [=y] > > > > To resolve this, add CONFIG_PAGE_SIZE_LESS_THAN_256KB as a dependency of > > CONFIG_TEST_KMOD so there is no more invalid configuration or build > > errors. > > > > Link: https://lkml.kernel.org/r/20211129230141.228085-4-nathan@xxxxxxxxxx > > Fixes: b05fbcc36be1 ("btrfs: disable build on platforms having page size 256K") > > Signed-off-by: Nathan Chancellor <nathan@xxxxxxxxxx> > > Reported-by: kernel test robot <lkp@xxxxxxxxx> > > Cc: Chris Mason <clm@xxxxxx> > > Cc: David Sterba <dsterba@xxxxxxxx> > > Cc: Josef Bacik <josef@xxxxxxxxxxxxxx> > > Cc: Luis Chamberlain <mcgrof@xxxxxxxxxx> > > Cc: Nick Desaulniers <ndesaulniers@xxxxxxxxxx> > > Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> > > Signed-off-by: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> > > Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> > > --- > > lib/Kconfig.debug | 1 + > > 1 file changed, 1 insertion(+) > > > > --- a/lib/Kconfig.debug > > +++ b/lib/Kconfig.debug > > @@ -2487,6 +2487,7 @@ config TEST_KMOD > > depends on m > > depends on NETDEVICES && NET_CORE && INET # for TUN > > depends on BLOCK > > + depends on PAGE_SIZE_LESS_THAN_256KB # for BTRFS > > select TEST_LKM > > select XFS_FS > > select TUN > > This patch depends on commit e4bbd20d8c2b ("arch/Kconfig: split > PAGE_SIZE_LESS_THAN_256KB from PAGE_SIZE_LESS_THAN_64KB"), which I do > not see queued up anywhere. That patch depends on commit 1f0e290cc5fd > ("arch: Add generic Kconfig option indicating page size smaller than > 64k"), which I only see in 5.16 or newer. > > If those two commits pick clean on a stable tree that contains > b05fbcc36be1, then this should be an okay backport. If not, then I would > just say we can drop the patches and leave this issue be until someone > actually hits it in practice. It was uncovered by a randconfig, it is > unlikely that 256K pages are actually being used by Hexagon in the wild > (that is, if anyone is even running mainline or recent stable releases > on Hexagon). Ok, now dropped, thanks. greg k-h
