This is a note to let you know that I've just added the patch titled
lib82596: Fix IRQ check in sni_82596_probe
to the 5.16-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
lib82596-fix-irq-check-in-sni_82596_probe.patch
and it can be found in the queue-5.16 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.
>From 99218cbf81bf21355a3de61cd46a706d36e900e6 Mon Sep 17 00:00:00 2001
From: Miaoqian Lin <linmq006@xxxxxxxxx>
Date: Fri, 14 Jan 2022 06:57:24 +0000
Subject: lib82596: Fix IRQ check in sni_82596_probe
From: Miaoqian Lin <linmq006@xxxxxxxxx>
commit 99218cbf81bf21355a3de61cd46a706d36e900e6 upstream.
platform_get_irq() returns negative error number instead 0 on failure.
And the doc of platform_get_irq() provides a usage example:
int irq = platform_get_irq(pdev, 0);
if (irq < 0)
return irq;
Fix the check of return value to catch errors correctly.
Fixes: 115978859272 ("i825xx: Move the Intel 82586/82593/82596 based drivers")
Signed-off-by: Miaoqian Lin <linmq006@xxxxxxxxx>
Signed-off-by: David S. Miller <davem@xxxxxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
---
drivers/net/ethernet/i825xx/sni_82596.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
--- a/drivers/net/ethernet/i825xx/sni_82596.c
+++ b/drivers/net/ethernet/i825xx/sni_82596.c
@@ -117,9 +117,10 @@ static int sni_82596_probe(struct platfo
netdevice->dev_addr[5] = readb(eth_addr + 0x06);
iounmap(eth_addr);
- if (!netdevice->irq) {
+ if (netdevice->irq < 0) {
printk(KERN_ERR "%s: IRQ not found for i82596 at 0x%lx\n",
__FILE__, netdevice->base_addr);
+ retval = netdevice->irq;
goto probe_failed;
}
Patches currently in stable-queue which might be from linmq006@xxxxxxxxx are
queue-5.16/drm-sun4i-dw-hdmi-fix-missing-put_device-call-in-sun.patch
queue-5.16/usb-dwc3-qcom-fix-null-vs-is_err-checking-in-dwc3_qc.patch
queue-5.16/phy-mediatek-fix-missing-check-in-mtk_mipi_tx_probe.patch
queue-5.16/gpio-mpc8xxx-fix-irq-check-in-mpc8xxx_probe.patch
queue-5.16/drivers-firmware-add-missing-platform_device_put-in-.patch
queue-5.16/parisc-pdc_stable-fix-memory-leak-in-pdcs_register_pathentries.patch
queue-5.16/gpio-idt3243x-fix-irq-check-in-idt_gpio_probe.patch
queue-5.16/lib82596-fix-irq-check-in-sni_82596_probe.patch
queue-5.16/scsi-ufs-ufs-mediatek-fix-error-checking-in-ufs_mtk_init_va09_pwr_ctrl.patch
queue-5.16/bluetooth-hci_qca-fix-null-vs-is_err_or_null-check-i.patch
queue-5.16/spi-spi-meson-spifc-add-missing-pm_runtime_disable-i.patch
