This is a note to let you know that I've just added the patch titled
ext4: fast commit may miss tracking unwritten range during ftruncate
to the 5.10-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
ext4-fast-commit-may-miss-tracking-unwritten-range-during-ftruncate.patch
and it can be found in the queue-5.10 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.
>From 9725958bb75cdfa10f2ec11526fdb23e7485e8e4 Mon Sep 17 00:00:00 2001
From: Xin Yin <yinxin.x@xxxxxxxxxxxxx>
Date: Thu, 23 Dec 2021 11:23:37 +0800
Subject: ext4: fast commit may miss tracking unwritten range during ftruncate
From: Xin Yin <yinxin.x@xxxxxxxxxxxxx>
commit 9725958bb75cdfa10f2ec11526fdb23e7485e8e4 upstream.
If use FALLOC_FL_KEEP_SIZE to alloc unwritten range at bottom, the
inode->i_size will not include the unwritten range. When call
ftruncate with fast commit enabled, it will miss to track the
unwritten range.
Change to trace the full range during ftruncate.
Signed-off-by: Xin Yin <yinxin.x@xxxxxxxxxxxxx>
Reviewed-by: Harshad Shirwadkar <harshadshirwadkar@xxxxxxxxx>
Link: https://lore.kernel.org/r/20211223032337.5198-3-yinxin.x@xxxxxxxxxxxxx
Signed-off-by: Theodore Ts'o <tytso@xxxxxxx>
Cc: stable@xxxxxxxxxx
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
---
fs/ext4/inode.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
--- a/fs/ext4/inode.c
+++ b/fs/ext4/inode.c
@@ -5468,8 +5468,7 @@ int ext4_setattr(struct dentry *dentry,
ext4_fc_track_range(handle, inode,
(attr->ia_size > 0 ? attr->ia_size - 1 : 0) >>
inode->i_sb->s_blocksize_bits,
- (oldsize > 0 ? oldsize - 1 : 0) >>
- inode->i_sb->s_blocksize_bits);
+ EXT_MAX_BLOCKS - 1);
else
ext4_fc_track_range(
handle, inode,
Patches currently in stable-queue which might be from yinxin.x@xxxxxxxxxxxxx are
queue-5.10/ext4-fast-commit-may-miss-tracking-unwritten-range-during-ftruncate.patch
queue-5.10/ext4-use-ext4_ext_remove_space-for-fast-commit-replay-delete-range.patch
queue-5.10/ext4-fix-fast-commit-may-miss-tracking-range-for-falloc_fl_zero_range.patch
