This is a note to let you know that I've just added the patch titled can: gs_usb: gs_can_start_xmit(): zero-initialize hf->{flags,reserved} to the 4.19-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: can-gs_usb-gs_can_start_xmit-zero-initialize-hf-flags-reserved.patch and it can be found in the queue-4.19 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let <stable@xxxxxxxxxxxxxxx> know about it. >From 89d58aebe14a365c25ba6645414afdbf4e41cea4 Mon Sep 17 00:00:00 2001 From: Brian Silverman <brian.silverman@xxxxxxxxxxxxxxxxx> Date: Wed, 5 Jan 2022 16:29:50 -0800 Subject: can: gs_usb: gs_can_start_xmit(): zero-initialize hf->{flags,reserved} From: Brian Silverman <brian.silverman@xxxxxxxxxxxxxxxxx> commit 89d58aebe14a365c25ba6645414afdbf4e41cea4 upstream. No information is deliberately sent in hf->flags in host -> device communications, but the open-source candleLight firmware echoes it back, which can result in the GS_CAN_FLAG_OVERFLOW flag being set and generating spurious ERRORFRAMEs. While there also initialize the reserved member with 0. Fixes: d08e973a77d1 ("can: gs_usb: Added support for the GS_USB CAN devices") Link: https://lore.kernel.org/all/20220106002952.25883-1-brian.silverman@xxxxxxxxxxxxxxxxx Link: https://github.com/candle-usb/candleLight_fw/issues/87 Cc: stable@xxxxxxxxxxxxxxx Signed-off-by: Brian Silverman <brian.silverman@xxxxxxxxxxxxxxxxx> [mkl: initialize the reserved member, too] Signed-off-by: Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> --- drivers/net/can/usb/gs_usb.c | 2 ++ 1 file changed, 2 insertions(+) --- a/drivers/net/can/usb/gs_usb.c +++ b/drivers/net/can/usb/gs_usb.c @@ -515,6 +515,8 @@ static netdev_tx_t gs_can_start_xmit(str hf->echo_id = idx; hf->channel = dev->channel; + hf->flags = 0; + hf->reserved = 0; cf = (struct can_frame *)skb->data; Patches currently in stable-queue which might be from brian.silverman@xxxxxxxxxxxxxxxxx are queue-4.19/can-gs_usb-gs_can_start_xmit-zero-initialize-hf-flags-reserved.patch