This is a note to let you know that I've just added the patch titled
mfd: intel-lpss-pci: Fix clock speed for 38a8 UART
to the 5.16-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
mfd-intel-lpss-pci-fix-clock-speed-for-38a8-uart.patch
and it can be found in the queue-5.16 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.
>From 9651cf2cb14726c785240e9dc01b274a68e9959e Mon Sep 17 00:00:00 2001
From: Orlando Chamberlain <redecorating@xxxxxxxxxxxxxx>
Date: Wed, 24 Nov 2021 09:19:44 +0000
Subject: mfd: intel-lpss-pci: Fix clock speed for 38a8 UART
From: Orlando Chamberlain <redecorating@xxxxxxxxxxxxxx>
commit 9651cf2cb14726c785240e9dc01b274a68e9959e upstream.
This device is found in the MacBookPro16,2, and as the MacBookPro16,1 is
from the same generation of MacBooks and has a UART with bxt_uart_info,
it was incorrectly assumed that the MacBookPro16,2's UART would have the
same info.
This led to the wrong clock speed being used, and the Bluetooth
controller exposed by the UART receiving and sending random data, which
was incorrectly assumed to be an issue with the Bluetooth stuff, not an
error with the UART side of things.
Changing the info to spt_uart_info changes the clock speed and makes it
send and receive data correctly.
Fixes: ddb1ada416fd ("mfd: intel-lpss: Add support for MacBookPro16,2 ICL-N UART")
Signed-off-by: Orlando Chamberlain <redecorating@xxxxxxxxxxxxxx>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Signed-off-by: Lee Jones <lee.jones@xxxxxxxxxx>
Cc: Aditya Garg <gargaditya08@xxxxxxxx>
Link: https://lore.kernel.org/r/20211124091846.11114-1-redecorating@xxxxxxxxxxxxxx
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
---
drivers/mfd/intel-lpss-pci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/mfd/intel-lpss-pci.c
+++ b/drivers/mfd/intel-lpss-pci.c
@@ -254,7 +254,7 @@ static const struct pci_device_id intel_
{ PCI_VDEVICE(INTEL, 0x34eb), (kernel_ulong_t)&bxt_i2c_info },
{ PCI_VDEVICE(INTEL, 0x34fb), (kernel_ulong_t)&spt_info },
/* ICL-N */
- { PCI_VDEVICE(INTEL, 0x38a8), (kernel_ulong_t)&bxt_uart_info },
+ { PCI_VDEVICE(INTEL, 0x38a8), (kernel_ulong_t)&spt_uart_info },
/* TGL-H */
{ PCI_VDEVICE(INTEL, 0x43a7), (kernel_ulong_t)&bxt_uart_info },
{ PCI_VDEVICE(INTEL, 0x43a8), (kernel_ulong_t)&bxt_uart_info },
Patches currently in stable-queue which might be from redecorating@xxxxxxxxxxxxxx are
queue-5.16/bluetooth-add-quirk-disabling-le-read-transmit-power.patch
queue-5.16/mfd-intel-lpss-pci-fix-clock-speed-for-38a8-uart.patch
queue-5.16/mfd-intel-lpss-fix-too-early-pm-enablement-in-the-acpi-probe.patch
queue-5.16/bluetooth-btbcm-disable-read-tx-power-for-some-macs-with-the-t2-security-chip.patch
