This is a note to let you know that I've just added the patch titled usb: cdnsp: Fix lack of spin_lock_irqsave/spin_lock_restore to the 5.15-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: usb-cdnsp-fix-lack-of-spin_lock_irqsave-spin_lock_restore.patch and it can be found in the queue-5.15 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let <stable@xxxxxxxxxxxxxxx> know about it. >From 4c4e162d9cf38528c4f13df09d5755cbc06f6c77 Mon Sep 17 00:00:00 2001 From: Pawel Laszczak <pawell@xxxxxxxxxxx> Date: Tue, 14 Dec 2021 05:55:27 +0100 Subject: usb: cdnsp: Fix lack of spin_lock_irqsave/spin_lock_restore From: Pawel Laszczak <pawell@xxxxxxxxxxx> commit 4c4e162d9cf38528c4f13df09d5755cbc06f6c77 upstream. Patch puts content of cdnsp_gadget_pullup function inside spin_lock_irqsave and spin_lock_restore section. This construction is required here to keep the data consistency, otherwise some data can be changed e.g. from interrupt context. Fixes: 3d82904559f4 ("usb: cdnsp: cdns3 Add main part of Cadence USBSSP DRD Driver") Reported-by: Ken (Jian) He <jianhe@xxxxxxxxxxxxx> cc: <stable@xxxxxxxxxxxxxxx> Signed-off-by: Pawel Laszczak <pawell@xxxxxxxxxxx> Reviewed-by: Peter Chen <peter.chen@xxxxxxxxxx> Link: https://lore.kernel.org/r/20211214045527.26823-1-pawell@xxxxxxxxxxxxxxxxxxxxx Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> --- drivers/usb/cdns3/cdnsp-gadget.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) --- a/drivers/usb/cdns3/cdnsp-gadget.c +++ b/drivers/usb/cdns3/cdnsp-gadget.c @@ -1541,15 +1541,27 @@ static int cdnsp_gadget_pullup(struct us { struct cdnsp_device *pdev = gadget_to_cdnsp(gadget); struct cdns *cdns = dev_get_drvdata(pdev->dev); + unsigned long flags; trace_cdnsp_pullup(is_on); + /* + * Disable events handling while controller is being + * enabled/disabled. + */ + disable_irq(cdns->dev_irq); + spin_lock_irqsave(&pdev->lock, flags); + if (!is_on) { cdnsp_reset_device(pdev); cdns_clear_vbus(cdns); } else { cdns_set_vbus(cdns); } + + spin_unlock_irqrestore(&pdev->lock, flags); + enable_irq(cdns->dev_irq); + return 0; } Patches currently in stable-queue which might be from pawell@xxxxxxxxxxx are queue-5.15/usb-cdnsp-fix-lack-of-spin_lock_irqsave-spin_lock_restore.patch queue-5.15/usb-cdnsp-fix-issue-in-cdnsp_log_ep-trace-event.patch queue-5.15/usb-cdnsp-fix-incorrect-calling-of-cdnsp_died-function.patch queue-5.15/usb-cdnsp-fix-incorrect-status-for-control-request.patch