This is a note to let you know that I've just added the patch titled
btrfs: remove stale comment about the btrfs_show_devname
to the 5.15-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
btrfs-remove-stale-comment-about-the-btrfs_show_devname.patch
and it can be found in the queue-5.15 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.
>From foo@baz Fri Dec 17 03:55:51 PM CET 2021
From: Anand Jain <anand.jain@xxxxxxxxxx>
Date: Thu, 16 Dec 2021 21:04:13 +0800
Subject: btrfs: remove stale comment about the btrfs_show_devname
To: linux-kernel@xxxxxxxxxxxxxxx, stable@xxxxxxxxxxxxxxx
Cc: linux-btrfs@xxxxxxxxxxxxxxx, Anand Jain <anand.jain@xxxxxxxxxx>, David Sterba <dsterba@xxxxxxxx>
Message-ID: <2fe0e10df7494300346f88470230a883f20753c4.1639658429.git.anand.jain@xxxxxxxxxx>
From: Anand Jain <anand.jain@xxxxxxxxxx>
Commit cdccc03a8a369b59cff5e7ea3292511cfa551120 upstream.
There were few lockdep warnings because btrfs_show_devname() was using
device_list_mutex as recorded in the commits:
0ccd05285e7f ("btrfs: fix a possible umount deadlock")
779bf3fefa83 ("btrfs: fix lock dep warning, move scratch dev out of device_list_mutex and uuid_mutex")
And finally, commit 88c14590cdd6 ("btrfs: use RCU in btrfs_show_devname
for device list traversal") removed the device_list_mutex from
btrfs_show_devname for performance reasons.
This patch removes a stale comment about the function
btrfs_show_devname and device_list_mutex.
Signed-off-by: Anand Jain <anand.jain@xxxxxxxxxx>
Reviewed-by: David Sterba <dsterba@xxxxxxxx>
Signed-off-by: David Sterba <dsterba@xxxxxxxx>
Signed-off-by: Anand Jain <anand.jain@xxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
---
fs/btrfs/volumes.c | 7 -------
1 file changed, 7 deletions(-)
--- a/fs/btrfs/volumes.c
+++ b/fs/btrfs/volumes.c
@@ -2312,13 +2312,6 @@ void btrfs_destroy_dev_replace_tgtdev(st
mutex_unlock(&fs_devices->device_list_mutex);
- /*
- * The update_dev_time() with in btrfs_scratch_superblocks()
- * may lead to a call to btrfs_show_devname() which will try
- * to hold device_list_mutex. And here this device
- * is already out of device list, so we don't have to hold
- * the device_list_mutex lock.
- */
btrfs_scratch_superblocks(tgtdev->fs_info, tgtdev->bdev,
tgtdev->name->str);
Patches currently in stable-queue which might be from anand.jain@xxxxxxxxxx are
queue-5.15/btrfs-use-latest_dev-in-btrfs_show_devname.patch
queue-5.15/btrfs-convert-latest_bdev-type-to-btrfs_device-and-rename.patch
queue-5.15/btrfs-remove-stale-comment-about-the-btrfs_show_devname.patch
queue-5.15/btrfs-update-latest_dev-when-we-create-a-sprout-device.patch
