This is a note to let you know that I've just added the patch titled perf intel-pt: Fix next 'err' value, walking trace to the 5.10-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: perf-intel-pt-fix-next-err-value-walking-trace.patch and it can be found in the queue-5.10 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let <stable@xxxxxxxxxxxxxxx> know about it. >From foo@baz Wed Dec 15 02:59:52 PM CET 2021 From: Adrian Hunter <adrian.hunter@xxxxxxxxx> Date: Mon, 13 Dec 2021 17:45:46 +0200 Subject: perf intel-pt: Fix next 'err' value, walking trace To: stable@xxxxxxxxxxxxxxx Message-ID: <20211213154548.122728-7-adrian.hunter@xxxxxxxxx> From: Adrian Hunter <adrian.hunter@xxxxxxxxx> commit a32e6c5da599dbf49e60622a4dfb5b9b40ece029 upstream. Code after label 'next:' in intel_pt_walk_trace() assumes 'err' is zero, but it may not be, if arrived at via a 'goto'. Ensure it is zero. Fixes: 7c1b16ba0e26e6 ("perf intel-pt: Add support for decoding FUP/TIP only") Signed-off-by: Adrian Hunter <adrian.hunter@xxxxxxxxx> Cc: Jiri Olsa <jolsa@xxxxxxxxxx> Cc: stable@xxxxxxxxxxxxxxx # v5.15+ Link: https://lore.kernel.org/r/20211210162303.2288710-6-adrian.hunter@xxxxxxxxx Signed-off-by: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx> [Adrian: Backport to v5.10] Signed-off-by: Adrian Hunter <adrian.hunter@xxxxxxxxx> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> --- tools/perf/util/intel-pt-decoder/intel-pt-decoder.c | 1 + 1 file changed, 1 insertion(+) --- a/tools/perf/util/intel-pt-decoder/intel-pt-decoder.c +++ b/tools/perf/util/intel-pt-decoder/intel-pt-decoder.c @@ -2068,6 +2068,7 @@ static int intel_pt_walk_trace(struct in if (err) return err; next: + err = 0; if (decoder->cyc_threshold) { if (decoder->sample_cyc && last_packet_type != INTEL_PT_CYC) decoder->sample_cyc = false; Patches currently in stable-queue which might be from adrian.hunter@xxxxxxxxx are queue-5.10/perf-intel-pt-fix-some-pge-packet-generation-enable-control-flow-packets-usage.patch queue-5.10/perf-intel-pt-fix-intel_pt_fup_event-assumptions-about-setting-state-type.patch queue-5.10/perf-intel-pt-fix-next-err-value-walking-trace.patch queue-5.10/perf-intel-pt-fix-error-timestamp-setting-on-the-decoder-error-path.patch queue-5.10/perf-intel-pt-fix-state-setting-when-receiving-overflow-ovf-packet.patch queue-5.10/perf-intel-pt-fix-sync-state-when-a-psb-synchronization-packet-is-found.patch queue-5.10/perf-inject-fix-itrace-space-allowed-for-new-attributes.patch queue-5.10/perf-intel-pt-fix-missing-instruction-events-with-q-option.patch