Patch "net: mscc: ocelot: don't downgrade timestamping RX filters in SIOCSHWTSTAMP" has been added to the 5.10-stable tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This is a note to let you know that I've just added the patch titled

    net: mscc: ocelot: don't downgrade timestamping RX filters in SIOCSHWTSTAMP

to the 5.10-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     net-mscc-ocelot-don-t-downgrade-timestamping-rx-filt.patch
and it can be found in the queue-5.10 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.



commit c5ba381e2c2c9b75db337b78e65125ffb03dac5c
Author: Vladimir Oltean <vladimir.oltean@xxxxxxx>
Date:   Fri Nov 26 19:28:41 2021 +0200

    net: mscc: ocelot: don't downgrade timestamping RX filters in SIOCSHWTSTAMP
    
    [ Upstream commit 8a075464d1e9317ffae0973dfe538a7511291a06 ]
    
    The ocelot driver, when asked to timestamp all receiving packets, 1588
    v1 or NTP, says "nah, here's 1588 v2 for you".
    
    According to this discussion:
    https://patchwork.kernel.org/project/netdevbpf/patch/20211104133204.19757-8-martin.kaistra@xxxxxxxxxxxxx/#24577647
    drivers that downgrade from a wider request to a narrower response (or
    even a response where the intersection with the request is empty) are
    buggy, and should return -ERANGE instead. This patch fixes that.
    
    Fixes: 4e3b0468e6d7 ("net: mscc: PTP Hardware Clock (PHC) support")
    Suggested-by: Richard Cochran <richardcochran@xxxxxxxxx>
    Signed-off-by: Vladimir Oltean <vladimir.oltean@xxxxxxx>
    Acked-by: Richard Cochran <richardcochran@xxxxxxxxx>
    Signed-off-by: Jakub Kicinski <kuba@xxxxxxxxxx>
    Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>

diff --git a/drivers/net/ethernet/mscc/ocelot.c b/drivers/net/ethernet/mscc/ocelot.c
index 8c45b236649a9..154d67066d012 100644
--- a/drivers/net/ethernet/mscc/ocelot.c
+++ b/drivers/net/ethernet/mscc/ocelot.c
@@ -811,12 +811,6 @@ int ocelot_hwstamp_set(struct ocelot *ocelot, int port, struct ifreq *ifr)
 	switch (cfg.rx_filter) {
 	case HWTSTAMP_FILTER_NONE:
 		break;
-	case HWTSTAMP_FILTER_ALL:
-	case HWTSTAMP_FILTER_SOME:
-	case HWTSTAMP_FILTER_PTP_V1_L4_EVENT:
-	case HWTSTAMP_FILTER_PTP_V1_L4_SYNC:
-	case HWTSTAMP_FILTER_PTP_V1_L4_DELAY_REQ:
-	case HWTSTAMP_FILTER_NTP_ALL:
 	case HWTSTAMP_FILTER_PTP_V2_L4_EVENT:
 	case HWTSTAMP_FILTER_PTP_V2_L4_SYNC:
 	case HWTSTAMP_FILTER_PTP_V2_L4_DELAY_REQ:



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux