This is a note to let you know that I've just added the patch titled x86/Kconfig: Fix an unused variable error in dell-smm-hwmon to the 5.10-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: x86-kconfig-fix-an-unused-variable-error-in-dell-smm-hwmon.patch and it can be found in the queue-5.10 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let <stable@xxxxxxxxxxxxxxx> know about it. >From ef775a0e36c6a81c5b07cb228c02f967133fe768 Mon Sep 17 00:00:00 2001 From: Randy Dunlap <rdunlap@xxxxxxxxxxxxx> Date: Fri, 10 Sep 2021 00:19:21 -0700 Subject: x86/Kconfig: Fix an unused variable error in dell-smm-hwmon MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: Randy Dunlap <rdunlap@xxxxxxxxxxxxx> commit ef775a0e36c6a81c5b07cb228c02f967133fe768 upstream. When CONFIG_PROC_FS is not set, there is a build warning (turned into an error): ../drivers/hwmon/dell-smm-hwmon.c: In function 'i8k_init_procfs': ../drivers/hwmon/dell-smm-hwmon.c:624:24: error: unused variable 'data' [-Werror=unused-variable] struct dell_smm_data *data = dev_get_drvdata(dev); Make I8K depend on PROC_FS and HWMON (instead of selecting HWMON -- it is strongly preferred to not select entire subsystems). Build tested in all possible combinations of SENSORS_DELL_SMM, I8K, and PROC_FS. Fixes: 039ae58503f3 ("hwmon: Allow to compile dell-smm-hwmon driver without /proc/i8k") Reported-by: Arnd Bergmann <arnd@xxxxxxxx> Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx> Signed-off-by: Borislav Petkov <bp@xxxxxxx> Reviewed-by: Arnd Bergmann <arnd@xxxxxxxx> Acked-by: Guenter Roeck <linux@xxxxxxxxxxxx> Acked-by: Pali Rohár <pali@xxxxxxxxxx> Link: https://lkml.kernel.org/r/20210910071921.16777-1-rdunlap@xxxxxxxxxxxxx Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> --- arch/x86/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/arch/x86/Kconfig +++ b/arch/x86/Kconfig @@ -1266,7 +1266,8 @@ config TOSHIBA config I8K tristate "Dell i8k legacy laptop support" - select HWMON + depends on HWMON + depends on PROC_FS select SENSORS_DELL_SMM help This option enables legacy /proc/i8k userspace interface in hwmon Patches currently in stable-queue which might be from rdunlap@xxxxxxxxxxxxx are queue-5.10/sh-math-emu-drop-unused-functions.patch queue-5.10/mips-lantiq-add-support-for-clk_get_parent.patch queue-5.10/mips-bcm63xx-add-support-for-clk_get_parent.patch queue-5.10/sh-fix-kconfig-unmet-dependency-warning-for-frame_po.patch queue-5.10/x86-kconfig-fix-an-unused-variable-error-in-dell-smm-hwmon.patch queue-5.10/sh-define-__big_endian-for-math-emu.patch queue-5.10/mips-bcm63xx-ensure-that-cpu_supports_32bit_kernel-i.patch queue-5.10/alsa-isa-not-for-m68k.patch