Patch "ALSA: usb-audio: disable implicit feedback sync for Behringer UFX1204 and UFX1604" has been added to the 5.15-stable tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This is a note to let you know that I've just added the patch titled

    ALSA: usb-audio: disable implicit feedback sync for Behringer UFX1204 and UFX1604

to the 5.15-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     alsa-usb-audio-disable-implicit-feedback-sync-for-be.patch
and it can be found in the queue-5.15 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.



commit 4fb8627b74d15302762064f54d16533b01ea6946
Author: Geraldo Nascimento <geraldogabriel@xxxxxxxxx>
Date:   Thu Sep 30 16:40:14 2021 -0300

    ALSA: usb-audio: disable implicit feedback sync for Behringer UFX1204 and UFX1604
    
    [ Upstream commit 28c369e60827f706cef4604a3e2848198f25bd26 ]
    
    Behringer UFX1204 and UFX1604 have Synchronous endpoints to which
    current ALSA code applies implicit feedback sync as if they were
    Asynchronous endpoints. This breaks UAC compliance and is unneeded.
    
    The commit 5e35dc0338d85ccebacf3f77eca1e5dea73155e8 and subsequent
    1a15718b41df026cffd0e42cfdc38a1384ce19f9 were meant to clear up noise.
    
    Unfortunately, noise persisted for those using higher sample rates and
    this was only solved by commit d2e8f641257d0d3af6e45d6ac2d6f9d56b8ea964
    
    Since there are no more reports of noise, let's get rid of the
    implicit-fb quirks breaking UAC compliance.
    
    Signed-off-by: Geraldo Nascimento <geraldogabriel@xxxxxxxxx>
    Link: https://lore.kernel.org/r/YVYSnoQ7nxLXT0Dq@geday
    Signed-off-by: Takashi Iwai <tiwai@xxxxxxx>
    Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>

diff --git a/sound/usb/implicit.c b/sound/usb/implicit.c
index 23767a14d1266..70319c822c10b 100644
--- a/sound/usb/implicit.c
+++ b/sound/usb/implicit.c
@@ -54,8 +54,6 @@ static const struct snd_usb_implicit_fb_match playback_implicit_fb_quirks[] = {
 
 	/* Fixed EP */
 	/* FIXME: check the availability of generic matching */
-	IMPLICIT_FB_FIXED_DEV(0x1397, 0x0001, 0x81, 1), /* Behringer UFX1604 */
-	IMPLICIT_FB_FIXED_DEV(0x1397, 0x0002, 0x81, 1), /* Behringer UFX1204 */
 	IMPLICIT_FB_FIXED_DEV(0x2466, 0x8010, 0x81, 2), /* Fractal Audio Axe-Fx III */
 	IMPLICIT_FB_FIXED_DEV(0x31e9, 0x0001, 0x81, 2), /* Solid State Logic SSL2 */
 	IMPLICIT_FB_FIXED_DEV(0x31e9, 0x0002, 0x81, 2), /* Solid State Logic SSL2+ */



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux