Patch "soc: qcom: apr: Add of_node_put() before return" has been added to the 5.10-stable tree

[Sasha Levin <sashal@xxxxxxxxxx>]

This is a note to let you know that I've just added the patch titled

    soc: qcom: apr: Add of_node_put() before return

to the 5.10-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     soc-qcom-apr-add-of_node_put-before-return.patch
and it can be found in the queue-5.10 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.



commit da22791816462baf901e94340f1aae5c66c5e2c5
Author: Wan Jiabing <wanjiabing@xxxxxxxx>
Date:   Thu Oct 14 04:30:17 2021 -0400

    soc: qcom: apr: Add of_node_put() before return
    
    [ Upstream commit 72f1aa6205d84337b90b065f602a8fe190821781 ]
    
    Fix following coccicheck warning:
    
    ./drivers/soc/qcom/apr.c:485:1-23: WARNING: Function
    for_each_child_of_node should have of_node_put() before return
    
    Early exits from for_each_child_of_node should decrement the
    node reference counter.
    
    Fixes: 834735662602 ("soc: qcom: apr: Add avs/audio tracking functionality")
    Signed-off-by: Wan Jiabing <wanjiabing@xxxxxxxx>
    Signed-off-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx>
    Link: https://lore.kernel.org/r/20211014083017.19714-1-wanjiabing@xxxxxxxx
    Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>

diff --git a/drivers/soc/qcom/apr.c b/drivers/soc/qcom/apr.c
index 7abfc8c4fdc72..f736d208362c9 100644
--- a/drivers/soc/qcom/apr.c
+++ b/drivers/soc/qcom/apr.c
@@ -323,12 +323,14 @@ static int of_apr_add_pd_lookups(struct device *dev)
 						    1, &service_path);
 		if (ret < 0) {
 			dev_err(dev, "pdr service path missing: %d\n", ret);
+			of_node_put(node);
 			return ret;
 		}
 
 		pds = pdr_add_lookup(apr->pdr, service_name, service_path);
 		if (IS_ERR(pds) && PTR_ERR(pds) != -EALREADY) {
 			dev_err(dev, "pdr add lookup failed: %ld\n", PTR_ERR(pds));
+			of_node_put(node);
 			return PTR_ERR(pds);
 		}
 	}