Patch "drm/of: free the right object" has been added to the 5.14-stable tree

[Sasha Levin <sashal@xxxxxxxxxx>]

This is a note to let you know that I've just added the patch titled

    drm/of: free the right object

to the 5.14-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     drm-of-free-the-right-object.patch
and it can be found in the queue-5.14 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.



commit 154c5a0897548edfb7932ffda62127d4f2d8cef2
Author: Julia Lawall <Julia.Lawall@xxxxxxxx>
Date:   Fri Jul 9 22:07:17 2021 +0200

    drm/of: free the right object
    
    [ Upstream commit b557a5f8da5798d27370ed6b73e673aae33efd55 ]
    
    There is no need to free a NULL value.  Instead, free the object
    that is leaking due to the iterator.
    
    The semantic patch that finds this problem is as follows:
    
    // <smpl>
    @@
    expression x,e;
    identifier f;
    @@
     x = f(...);
     if (x == NULL) {
            ... when any
                when != x = e
    *       of_node_put(x);
            ...
     }
    // </smpl>
    
    Fixes: 6529007522de ("drm: of: Add drm_of_lvds_get_dual_link_pixel_order")
    Signed-off-by: Julia Lawall <Julia.Lawall@xxxxxxxx>
    Signed-off-by: Daniel Vetter <daniel.vetter@xxxxxxxx>
    Link: https://patchwork.freedesktop.org/patch/msgid/20210709200717.3676376-1-Julia.Lawall@xxxxxxxx
    Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>

diff --git a/drivers/gpu/drm/drm_of.c b/drivers/gpu/drm/drm_of.c
index ca04c34e8251..197c57477344 100644
--- a/drivers/gpu/drm/drm_of.c
+++ b/drivers/gpu/drm/drm_of.c
@@ -315,7 +315,7 @@ static int drm_of_lvds_get_remote_pixels_type(
 
 		remote_port = of_graph_get_remote_port(endpoint);
 		if (!remote_port) {
-			of_node_put(remote_port);
+			of_node_put(endpoint);
 			return -EPIPE;
 		}