This is a note to let you know that I've just added the patch titled Revert "cred: add missing return error code when set_cred_ucounts() failed" to the 5.10-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: revert-cred-add-missing-return-error-code-when-set_cred_ucounts-failed.patch and it can be found in the queue-5.10 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let <stable@xxxxxxxxxxxxxxx> know about it. >From eec93213380a70208bef125e866840b77b8df06e Mon Sep 17 00:00:00 2001 From: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> Date: Fri, 3 Sep 2021 16:06:40 +0200 Subject: Revert "cred: add missing return error code when set_cred_ucounts() failed" From: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> This reverts commit 0855952ed4f1a6861fbb0e5d684efd447d7347c9 which is commit 5e6b8a50a7cec5686ee2c4bda1d49899c79a7eae upstream. The "original" commit 905ae01c4ae2 ("Add a reference to ucounts for each cred"), should not have been applied to the 5.10.y tree, so revert it, and the follow-on fixup patches as well. Reported-by: "Eric W. Biederman" <ebiederm@xxxxxxxxxxxx> Link: https://lore.kernel.org/r/87v93k4bl6.fsf@disp2133 Cc: Yang Yingliang <yangyingliang@xxxxxxxxxx> Cc: Alexey Gladkov <legion@xxxxxxxxxx> Cc: Sasha Levin <sashal@xxxxxxxxxx> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> --- kernel/cred.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- a/kernel/cred.c +++ b/kernel/cred.c @@ -372,8 +372,7 @@ int copy_creds(struct task_struct *p, un ret = create_user_ns(new); if (ret < 0) goto error_put; - ret = set_cred_ucounts(new); - if (ret < 0) + if (set_cred_ucounts(new) < 0) goto error_put; } Patches currently in stable-queue which might be from gregkh@xxxxxxxxxxxxxxxxxxx are queue-5.10/ubifs-report-correct-st_size-for-encrypted-symlinks.patch queue-5.10/ext4-fix-race-writing-to-an-inline_data-file-while-its-xattrs-are-changing.patch queue-5.10/revert-cred-add-missing-return-error-code-when-set_cred_ucounts-failed.patch queue-5.10/ext4-report-correct-st_size-for-encrypted-symlinks.patch queue-5.10/revert-add-a-reference-to-ucounts-for-each-cred.patch queue-5.10/fscrypt-add-fscrypt_symlink_getattr-for-computing-st_size.patch queue-5.10/f2fs-report-correct-st_size-for-encrypted-symlinks.patch queue-5.10/revert-ucounts-increase-ucounts-reference-counter-before-the-security-hook.patch