This is a note to let you know that I've just added the patch titled
media: zr364xx: fix memory leak in zr364xx_start_readpipe
to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
media-zr364xx-fix-memory-leak-in-zr364xx_start_readpipe.patch
and it can be found in the queue-4.4 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.
>From 0a045eac8d0427b64577a24d74bb8347c905ac65 Mon Sep 17 00:00:00 2001
From: Pavel Skripkin <paskripkin@xxxxxxxxx>
Date: Mon, 17 May 2021 21:18:14 +0200
Subject: media: zr364xx: fix memory leak in zr364xx_start_readpipe
From: Pavel Skripkin <paskripkin@xxxxxxxxx>
commit 0a045eac8d0427b64577a24d74bb8347c905ac65 upstream.
syzbot reported memory leak in zr364xx driver.
The problem was in non-freed urb in case of
usb_submit_urb() fail.
backtrace:
[<ffffffff82baedf6>] kmalloc include/linux/slab.h:561 [inline]
[<ffffffff82baedf6>] usb_alloc_urb+0x66/0xe0 drivers/usb/core/urb.c:74
[<ffffffff82f7cce8>] zr364xx_start_readpipe+0x78/0x130 drivers/media/usb/zr364xx/zr364xx.c:1022
[<ffffffff84251dfc>] zr364xx_board_init drivers/media/usb/zr364xx/zr364xx.c:1383 [inline]
[<ffffffff84251dfc>] zr364xx_probe+0x6a3/0x851 drivers/media/usb/zr364xx/zr364xx.c:1516
[<ffffffff82bb6507>] usb_probe_interface+0x177/0x370 drivers/usb/core/driver.c:396
[<ffffffff826018a9>] really_probe+0x159/0x500 drivers/base/dd.c:576
Fixes: ccbf035ae5de ("V4L/DVB (12278): zr364xx: implement V4L2_CAP_STREAMING")
Cc: stable@xxxxxxxxxxxxxxx
Reported-by: syzbot+af4fa391ef18efdd5f69@xxxxxxxxxxxxxxxxxxxxxxxxx
Signed-off-by: Pavel Skripkin <paskripkin@xxxxxxxxx>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xxxxxxxxx>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@xxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
---
drivers/media/usb/zr364xx/zr364xx.c | 1 +
1 file changed, 1 insertion(+)
--- a/drivers/media/usb/zr364xx/zr364xx.c
+++ b/drivers/media/usb/zr364xx/zr364xx.c
@@ -1068,6 +1068,7 @@ static int zr364xx_start_readpipe(struct
DBG("submitting URB %p\n", pipe_info->stream_urb);
retval = usb_submit_urb(pipe_info->stream_urb, GFP_KERNEL);
if (retval) {
+ usb_free_urb(pipe_info->stream_urb);
printk(KERN_ERR KBUILD_MODNAME ": start read pipe failed\n");
return retval;
}
Patches currently in stable-queue which might be from paskripkin@xxxxxxxxx are
queue-4.4/reiserfs-add-check-for-invalid-1st-journal-block.patch
queue-4.4/net-ethernet-aeroflex-fix-uaf-in-greth_of_remove.patch
queue-4.4/net-ethernet-ezchip-fix-uaf-in-nps_enet_remove.patch
queue-4.4/net-can-ems_usb-fix-use-after-free-in-ems_usb_disconnect.patch
queue-4.4/media-cpia2-fix-memory-leak-in-cpia2_usb_probe.patch
queue-4.4/net-ethernet-ezchip-fix-error-handling.patch
queue-4.4/media-dvb-usb-fix-wrong-definition.patch
queue-4.4/media-zr364xx-fix-memory-leak-in-zr364xx_start_readpipe.patch
