This is a note to let you know that I've just added the patch titled Revert "serial: mvebu-uart: Fix to avoid a potential NULL pointer dereference" to the 5.4-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: revert-serial-mvebu-uart-fix-to-avoid-a-potential-null-pointer-dereference.patch and it can be found in the queue-5.4 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let <stable@xxxxxxxxxxxxxxx> know about it. >From 754f39158441f4c0d7a8255209dd9a939f08ce80 Mon Sep 17 00:00:00 2001 From: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> Date: Mon, 3 May 2021 13:56:32 +0200 Subject: Revert "serial: mvebu-uart: Fix to avoid a potential NULL pointer dereference" From: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> commit 754f39158441f4c0d7a8255209dd9a939f08ce80 upstream. This reverts commit 32f47179833b63de72427131169809065db6745e. Because of recent interactions with developers from @umn.edu, all commits from them have been recently re-reviewed to ensure if they were correct or not. Upon review, this commit was found to be not be needed at all as the change was useless because this function can only be called when of_match_device matched on something. So it should be reverted. Cc: Aditya Pakki <pakki001@xxxxxxx> Cc: stable <stable@xxxxxxxxxxxxxxx> Fixes: 32f47179833b ("serial: mvebu-uart: Fix to avoid a potential NULL pointer dereference") Acked-by: Jiri Slaby <jirislaby@xxxxxxxxxx> Link: https://lore.kernel.org/r/20210503115736.2104747-6-gregkh@xxxxxxxxxxxxxxxxxxx Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> --- drivers/tty/serial/mvebu-uart.c | 3 --- 1 file changed, 3 deletions(-) --- a/drivers/tty/serial/mvebu-uart.c +++ b/drivers/tty/serial/mvebu-uart.c @@ -818,9 +818,6 @@ static int mvebu_uart_probe(struct platf return -EINVAL; } - if (!match) - return -ENODEV; - /* Assume that all UART ports have a DT alias or none has */ id = of_alias_get_id(pdev->dev.of_node, "serial"); if (!pdev->dev.of_node || id < 0) Patches currently in stable-queue which might be from gregkh@xxxxxxxxxxxxxxxxxxx are queue-5.4/alsa-hda-realtek-fix-silent-headphone-output-on-asus-ux430ua.patch queue-5.4/alsa-hda-realtek-add-fixup-for-hp-omen-laptop.patch queue-5.4/alsa-intel8x0-don-t-update-period-unless-prepared.patch queue-5.4/cifs-fix-memory-leak-in-smb2_copychunk_range.patch queue-5.4/alsa-hda-realtek-reset-eapd-coeff-to-default-value-for-alc287.patch queue-5.4/revert-serial-mvebu-uart-fix-to-avoid-a-potential-null-pointer-dereference.patch queue-5.4/revert-rapidio-fix-a-null-pointer-dereference-when-create_workqueue-fails.patch queue-5.4/alsa-bebob-oxfw-fix-kconfig-entry-for-mackie-d.2-pro.patch queue-5.4/alsa-line6-fix-racy-initialization-of-line6-midi.patch queue-5.4/alsa-firewire-lib-fix-calculation-for-size-of-ir-context-payload.patch queue-5.4/alsa-hda-realtek-add-fixup-for-hp-spectre-x360-15-df0xxx.patch queue-5.4/alsa-dice-fix-stream-format-for-tc-electronic-konnekt-live-at-high-sampling-transfer-frequency.patch queue-5.4/alsa-dice-fix-stream-format-at-middle-sampling-rate-for-alesis-io-26.patch queue-5.4/uio_hv_generic-fix-a-memory-leak-in-error-handling-paths.patch queue-5.4/alsa-firewire-lib-fix-check-for-the-size-of-isochronous-packet-payload.patch queue-5.4/alsa-usb-audio-validate-ms-endpoint-descriptors.patch queue-5.4/btrfs-avoid-rcu-stalls-while-running-delayed-iputs.patch queue-5.4/revert-alsa-sb8-add-a-check-for-request_region.patch queue-5.4/alsa-hda-fixup-headset-for-asus-gu502-laptop.patch queue-5.4/alsa-hda-realtek-add-some-clove-ssids-of-alc293.patch queue-5.4/rapidio-handle-create_workqueue-failure.patch