This is a note to let you know that I've just added the patch titled usb: dwc3: gadget: Return success always for kick transfer in ep queue to the 4.19-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: usb-dwc3-gadget-return-success-always-for-kick-transfer-in-ep-queue.patch and it can be found in the queue-4.19 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let <stable@xxxxxxxxxxxxxxx> know about it. >From 18ffa988dbae69cc6e9949cddd9606f6fe533894 Mon Sep 17 00:00:00 2001 From: Wesley Cheng <wcheng@xxxxxxxxxxxxxx> Date: Fri, 7 May 2021 10:55:19 -0700 Subject: usb: dwc3: gadget: Return success always for kick transfer in ep queue From: Wesley Cheng <wcheng@xxxxxxxxxxxxxx> commit 18ffa988dbae69cc6e9949cddd9606f6fe533894 upstream. If an error is received when issuing a start or update transfer command, the error handler will stop all active requests (including the current USB request), and call dwc3_gadget_giveback() to notify function drivers of the requests which have been stopped. Avoid returning an error for kick transfer during EP queue, to remove duplicate cleanup operations on the request being queued. Fixes: 8d99087c2db8 ("usb: dwc3: gadget: Properly handle failed kick_transfer") cc: stable@xxxxxxxxxxxxxxx Signed-off-by: Wesley Cheng <wcheng@xxxxxxxxxxxxxx> Link: https://lore.kernel.org/r/1620410119-24971-1-git-send-email-wcheng@xxxxxxxxxxxxxx Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> --- drivers/usb/dwc3/gadget.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) --- a/drivers/usb/dwc3/gadget.c +++ b/drivers/usb/dwc3/gadget.c @@ -1413,7 +1413,9 @@ static int __dwc3_gadget_ep_queue(struct } } - return __dwc3_gadget_kick_transfer(dep); + __dwc3_gadget_kick_transfer(dep); + + return 0; } static int dwc3_gadget_ep_queue(struct usb_ep *ep, struct usb_request *request, Patches currently in stable-queue which might be from wcheng@xxxxxxxxxxxxxx are queue-4.19/usb-gadget-fix-double-free-of-device-descriptor-pointers.patch queue-4.19/usb-dwc3-gadget-return-success-always-for-kick-transfer-in-ep-queue.patch queue-4.19/usb-dwc3-gadget-ignore-ep-queue-requests-during-bus-.patch