Patch "of: overlay: fix for_each_child.cocci warnings" has been added to the 5.10-stable tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This is a note to let you know that I've just added the patch titled

    of: overlay: fix for_each_child.cocci warnings

to the 5.10-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     of-overlay-fix-for_each_child.cocci-warnings.patch
and it can be found in the queue-5.10 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.



commit 1cd22fc246aed8d1befad1ec7f7d2405a93536b1
Author: kernel test robot <lkp@xxxxxxxxx>
Date:   Mon Mar 22 19:21:39 2021 +0100

    of: overlay: fix for_each_child.cocci warnings
    
    [ Upstream commit c4d74f0f978ed5ceee62cd3f6708081042e582a1 ]
    
    Function "for_each_child_of_node" should have of_node_put() before goto.
    
    Generated by: scripts/coccinelle/iterators/for_each_child.cocci
    
    Fixes: 82c2d81361ec ("coccinelle: iterators: Add for_each_child.cocci script")
    CC: Sumera Priyadarsini <sylphrenadin@xxxxxxxxx>
    Reported-by: kernel test robot <lkp@xxxxxxxxx>
    Signed-off-by: kernel test robot <lkp@xxxxxxxxx>
    Signed-off-by: Julia Lawall <julia.lawall@xxxxxxxx>
    Reviewed-by: Frank Rowand <frank.rowand@xxxxxxxx>
    Tested-by: Frank Rowand <frank.rowand@xxxxxxxx>
    Link: https://lore.kernel.org/r/alpine.DEB.2.22.394.2103221918450.2918@hadrien
    Signed-off-by: Rob Herring <robh@xxxxxxxxxx>
    Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>

diff --git a/drivers/of/overlay.c b/drivers/of/overlay.c
index 50bbe0edf538..43a77d720008 100644
--- a/drivers/of/overlay.c
+++ b/drivers/of/overlay.c
@@ -796,6 +796,7 @@ static int init_overlay_changeset(struct overlay_changeset *ovcs,
 		if (!fragment->target) {
 			of_node_put(fragment->overlay);
 			ret = -EINVAL;
+			of_node_put(node);
 			goto err_free_fragments;
 		}
 



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux