This is a note to let you know that I've just added the patch titled net: ieee802154: fix nl802154 add llsec key to the 5.10-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: net-ieee802154-fix-nl802154-add-llsec-key.patch and it can be found in the queue-5.10 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let <stable@xxxxxxxxxxxxxxx> know about it. >From 20d5fe2d7103f5c43ad11a3d6d259e9d61165c35 Mon Sep 17 00:00:00 2001 From: Alexander Aring <aahringo@xxxxxxxxxx> Date: Sun, 21 Feb 2021 12:43:20 -0500 Subject: net: ieee802154: fix nl802154 add llsec key From: Alexander Aring <aahringo@xxxxxxxxxx> commit 20d5fe2d7103f5c43ad11a3d6d259e9d61165c35 upstream. This patch fixes a nullpointer dereference if NL802154_ATTR_SEC_KEY is not set by the user. If this is the case nl802154 will return -EINVAL. Reported-by: syzbot+ce4e062c2d51977ddc50@xxxxxxxxxxxxxxxxxxxxxxxxx Signed-off-by: Alexander Aring <aahringo@xxxxxxxxxx> Link: https://lore.kernel.org/r/20210221174321.14210-3-aahringo@xxxxxxxxxx Signed-off-by: Stefan Schmidt <stefan@xxxxxxxxxxxxxxxxxx> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> --- net/ieee802154/nl802154.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/net/ieee802154/nl802154.c +++ b/net/ieee802154/nl802154.c @@ -1544,7 +1544,8 @@ static int nl802154_add_llsec_key(struct struct ieee802154_llsec_key_id id = { }; u32 commands[NL802154_CMD_FRAME_NR_IDS / 32] = { }; - if (nla_parse_nested_deprecated(attrs, NL802154_KEY_ATTR_MAX, info->attrs[NL802154_ATTR_SEC_KEY], nl802154_key_policy, info->extack)) + if (!info->attrs[NL802154_ATTR_SEC_KEY] || + nla_parse_nested_deprecated(attrs, NL802154_KEY_ATTR_MAX, info->attrs[NL802154_ATTR_SEC_KEY], nl802154_key_policy, info->extack)) return -EINVAL; if (!attrs[NL802154_KEY_ATTR_USAGE_FRAMES] || Patches currently in stable-queue which might be from aahringo@xxxxxxxxxx are queue-5.10/net-ieee802154-fix-nl802154-del-llsec-devkey.patch queue-5.10/net-ieee802154-fix-nl802154-del-llsec-key.patch queue-5.10/net-ieee802154-forbid-monitor-for-del-llsec-seclevel.patch queue-5.10/net-ieee802154-fix-nl802154-add-llsec-key.patch queue-5.10/net-ieee802154-forbid-monitor-for-set-llsec-params.patch queue-5.10/net-ieee802154-nl-mac-fix-check-on-panid.patch queue-5.10/net-mac802154-fix-general-protection-fault.patch queue-5.10/net-ieee802154-fix-nl802154-del-llsec-dev.patch queue-5.10/net-ieee802154-stop-dump-llsec-params-for-monitors.patch